You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@openjpa.apache.org by Harald Wellmann <hw...@gmail.com> on 2013/11/27 15:52:10 UTC
Auditor issue after upgrading to OpenJPA 2.3.0
After upgrading from OpenJPA 2.2.2 to 2.3.0, one of my regression tests
fails since Auditor.audit() delivers too many objects. In particular, after
changing a given field from x to y, some of the updated objects occur
twice, with the surplus occurrence reporting the field as changed from y to
y.
Is this a known issue?
The changes affect an embeddable type which occurs twice in a given entity:
@Entity
@Auditable
public class Container {
@AttributeOverrides(...)
private Item leftItem;
@AttributeOverrides(...)
private Item rightItem;
}
@Embeddable
@Auditable(values = { AuditableOperation.UPDATE })
public class Item {
}
Best regards,
Harald
Re: Auditor issue after upgrading to OpenJPA 2.3.0
Posted by Mark Struberg <st...@yahoo.de>.
No worries. I am currently tweaking my slides for a 3 days workshop next week.
After that I have time to look at this stuff.
Reminds me that I still need to merge a few commits from 2.3.0 to trunk + ship the site build :/
LieGrue,
strub
----- Original Message -----
> From: Rick Curtis <cu...@gmail.com>
> To: users <us...@openjpa.apache.org>
> Cc: Mark Struberg <st...@yahoo.de>
> Sent: Thursday, 5 December 2013, 15:35
> Subject: Re: Auditor issue after upgrading to OpenJPA 2.3.0
>
> Mark --
>
> I'll also note that I'm having problems with the changes that were done
> for
> OPENJPA-2437 with some internal tests. My test failures are different than
> Harald's though.
>
> It's a long story as to why the problem wasn't uncovered earlier but I
> hope
> to get time to look at it later today or tomorrow.
>
>
>
> On Thu, Dec 5, 2013 at 8:16 AM, Harald Wellmann
> <hw...@gmail.com>wrote:
>
>> Please see https://issues.apache.org/jira/browse/OPENJPA-2464. There's
> a
>> test case attached.
>>
>> Best regards,
>> Harald
>>
>>
>> 2013/11/27 Mark Struberg <st...@yahoo.de>
>>
>> > This is not known, but we moved the invocation of the auditing
> mechanism
>> > around a bit.
>> > There must be a JIRA which is tagged as 2.3.1.
>> >
>> > Please create a new JIRA for it and we will take a look.
>> >
>> > LieGrue,
>> > strub
>> >
>> >
>> >
>> > >________________________________
>> > > From: Harald Wellmann <hw...@gmail.com>
>> > >To: users@openjpa.apache.org
>> > >Sent: Wednesday, 27 November 2013, 15:52
>> > >Subject: Auditor issue after upgrading to OpenJPA 2.3.0
>> > >
>> > >
>> > >After upgrading from OpenJPA 2.2.2 to 2.3.0, one of my regression
> tests
>> > >fails since Auditor.audit() delivers too many objects. In
> particular,
>> > after
>> > >changing a given field from x to y, some of the updated objects
> occur
>> > >twice, with the surplus occurrence reporting the field as changed
> from y
>> > to
>> > >y.
>> > >
>> > >Is this a known issue?
>> > >
>> > >The changes affect an embeddable type which occurs twice in a
> given
>> > entity:
>> > >
>> > >@Entity
>> > >@Auditable
>> > >public class Container {
>> > >
>> > > @AttributeOverrides(...)
>> > > private Item leftItem;
>> > >
>> > > @AttributeOverrides(...)
>> > > private Item rightItem;
>> > >}
>> > >
>> > >@Embeddable
>> > >@Auditable(values = { AuditableOperation.UPDATE })
>> > >public class Item {
>> > >}
>> > >
>> > >Best regards,
>> > >Harald
>> > >
>> > >
>> > >
>> >
>>
>
>
>
> --
> *Rick Curtis*
>
Re: Auditor issue after upgrading to OpenJPA 2.3.0
Posted by Rick Curtis <cu...@gmail.com>.
Mark --
I'll also note that I'm having problems with the changes that were done for
OPENJPA-2437 with some internal tests. My test failures are different than
Harald's though.
It's a long story as to why the problem wasn't uncovered earlier but I hope
to get time to look at it later today or tomorrow.
On Thu, Dec 5, 2013 at 8:16 AM, Harald Wellmann <hw...@gmail.com>wrote:
> Please see https://issues.apache.org/jira/browse/OPENJPA-2464. There's a
> test case attached.
>
> Best regards,
> Harald
>
>
> 2013/11/27 Mark Struberg <st...@yahoo.de>
>
> > This is not known, but we moved the invocation of the auditing mechanism
> > around a bit.
> > There must be a JIRA which is tagged as 2.3.1.
> >
> > Please create a new JIRA for it and we will take a look.
> >
> > LieGrue,
> > strub
> >
> >
> >
> > >________________________________
> > > From: Harald Wellmann <hw...@gmail.com>
> > >To: users@openjpa.apache.org
> > >Sent: Wednesday, 27 November 2013, 15:52
> > >Subject: Auditor issue after upgrading to OpenJPA 2.3.0
> > >
> > >
> > >After upgrading from OpenJPA 2.2.2 to 2.3.0, one of my regression tests
> > >fails since Auditor.audit() delivers too many objects. In particular,
> > after
> > >changing a given field from x to y, some of the updated objects occur
> > >twice, with the surplus occurrence reporting the field as changed from y
> > to
> > >y.
> > >
> > >Is this a known issue?
> > >
> > >The changes affect an embeddable type which occurs twice in a given
> > entity:
> > >
> > >@Entity
> > >@Auditable
> > >public class Container {
> > >
> > > @AttributeOverrides(...)
> > > private Item leftItem;
> > >
> > > @AttributeOverrides(...)
> > > private Item rightItem;
> > >}
> > >
> > >@Embeddable
> > >@Auditable(values = { AuditableOperation.UPDATE })
> > >public class Item {
> > >}
> > >
> > >Best regards,
> > >Harald
> > >
> > >
> > >
> >
>
--
*Rick Curtis*
Re: Auditor issue after upgrading to OpenJPA 2.3.0
Posted by Harald Wellmann <hw...@gmail.com>.
Please see https://issues.apache.org/jira/browse/OPENJPA-2464. There's a
test case attached.
Best regards,
Harald
2013/11/27 Mark Struberg <st...@yahoo.de>
> This is not known, but we moved the invocation of the auditing mechanism
> around a bit.
> There must be a JIRA which is tagged as 2.3.1.
>
> Please create a new JIRA for it and we will take a look.
>
> LieGrue,
> strub
>
>
>
> >________________________________
> > From: Harald Wellmann <hw...@gmail.com>
> >To: users@openjpa.apache.org
> >Sent: Wednesday, 27 November 2013, 15:52
> >Subject: Auditor issue after upgrading to OpenJPA 2.3.0
> >
> >
> >After upgrading from OpenJPA 2.2.2 to 2.3.0, one of my regression tests
> >fails since Auditor.audit() delivers too many objects. In particular,
> after
> >changing a given field from x to y, some of the updated objects occur
> >twice, with the surplus occurrence reporting the field as changed from y
> to
> >y.
> >
> >Is this a known issue?
> >
> >The changes affect an embeddable type which occurs twice in a given
> entity:
> >
> >@Entity
> >@Auditable
> >public class Container {
> >
> > @AttributeOverrides(...)
> > private Item leftItem;
> >
> > @AttributeOverrides(...)
> > private Item rightItem;
> >}
> >
> >@Embeddable
> >@Auditable(values = { AuditableOperation.UPDATE })
> >public class Item {
> >}
> >
> >Best regards,
> >Harald
> >
> >
> >
>
Re: Auditor issue after upgrading to OpenJPA 2.3.0
Posted by Mark Struberg <st...@yahoo.de>.
This is not known, but we moved the invocation of the auditing mechanism around a bit.
There must be a JIRA which is tagged as 2.3.1.
Please create a new JIRA for it and we will take a look.
LieGrue,
strub
>________________________________
> From: Harald Wellmann <hw...@gmail.com>
>To: users@openjpa.apache.org
>Sent: Wednesday, 27 November 2013, 15:52
>Subject: Auditor issue after upgrading to OpenJPA 2.3.0
>
>
>After upgrading from OpenJPA 2.2.2 to 2.3.0, one of my regression tests
>fails since Auditor.audit() delivers too many objects. In particular, after
>changing a given field from x to y, some of the updated objects occur
>twice, with the surplus occurrence reporting the field as changed from y to
>y.
>
>Is this a known issue?
>
>The changes affect an embeddable type which occurs twice in a given entity:
>
>@Entity
>@Auditable
>public class Container {
>
> @AttributeOverrides(...)
> private Item leftItem;
>
> @AttributeOverrides(...)
> private Item rightItem;
>}
>
>@Embeddable
>@Auditable(values = { AuditableOperation.UPDATE })
>public class Item {
>}
>
>Best regards,
>Harald
>
>
>