[GitHub] [arrow] drin commented on pull request #13583: ARROW-16807: [C++][R] count distinct incorrectly merges state

[GitBox <gi...@apache.org>]

drin commented on PR #13583:
URL: https://github.com/apache/arrow/pull/13583#issuecomment-1183789572

   @wesm @westonpace previous pair of commits makes this work for scalar inputs. I tried putting some of the conditional logic ("if type is decimal") in `CountDistinctImpl` but it ended up being difficult to satisfy the compiler.
   
   the current change to UnboxScalar tries to essentially use `is_decimal`, but then I realized that there isn't an easy way to call the appriopriate view function unless I know which decimal type I have. Additionally, the UnboxScalar implementations for Decimal types gets the value, which I think would be difficult to downcast/change back to string_view.
   
   all in all, this was the only approach I could get to work and it seemed semi reasonable. Feedback would be much appreciated though.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org