You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/03/27 04:27:11 UTC
[GitHub] [flink] bowenli86 commented on a change in pull request #11538:
[FLINK-16813][jdbc] JDBCInputFormat doesn't correctly map Short
bowenli86 commented on a change in pull request #11538: [FLINK-16813][jdbc] JDBCInputFormat doesn't correctly map Short
URL: https://github.com/apache/flink/pull/11538#discussion_r399028594
##########
File path: flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
##########
@@ -127,7 +134,7 @@ public JDBCInputFormat() {
@Override
public RowTypeInfo getProducedType() {
- return rowTypeInfo;
+ return (RowTypeInfo) fromDataTypeToLegacyInfo(fromLogicalToDataType(rowType));
Review comment:
changed it because it's easier to check data types when converting a jdbc row to flink row.
would you recommend revert it given I've changed JdbcTypeUtil.normalizeTableSchema() in the latest commit I pushed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services