You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/07/23 06:49:00 UTC
[GitHub] [incubator-apisix] membphis opened a new pull request #1892: change: the timeout of `healthcheck` should be number type.
membphis opened a new pull request #1892:
URL: https://github.com/apache/incubator-apisix/pull/1892
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
as title.
### Pre-submission checklist:
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] membphis commented on a change in pull request #1892: change: the timeout of `healthcheck` should be number type.
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1892:
URL: https://github.com/apache/incubator-apisix/pull/1892#discussion_r460522256
##########
File path: doc/health-check.md
##########
@@ -78,6 +78,8 @@ contains: `active` or `passive`.
* `active`: To enable active health checks, you need to specify the configuration items under `checks.active` in the Upstream object configuration.
+ * `active.timeout`: Socket timeout for active checks (in seconds).
Review comment:
nice, fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] moonming merged pull request #1892: change: the timeout of `healthcheck` should be number type.
Posted by GitBox <gi...@apache.org>.
moonming merged pull request #1892:
URL: https://github.com/apache/incubator-apisix/pull/1892
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] moonming commented on a change in pull request #1892: change: the timeout of `healthcheck` should be number type.
Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #1892:
URL: https://github.com/apache/incubator-apisix/pull/1892#discussion_r459811262
##########
File path: doc/health-check.md
##########
@@ -78,6 +78,8 @@ contains: `active` or `passive`.
* `active`: To enable active health checks, you need to specify the configuration items under `checks.active` in the Upstream object configuration.
+ * `active.timeout`: Socket timeout for active checks (in seconds).
Review comment:
You should indicate support for decimals.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org