You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/10 19:38:01 UTC

[GitHub] [beam] ryanthompson591 commented on a diff in pull request #21801: Refactor API code to base.py in RunInference

ryanthompson591 commented on code in PR #21801:
URL: https://github.com/apache/beam/pull/21801#discussion_r894836860


##########
sdks/python/apache_beam/ml/inference/sklearn_inference_test.py:
##########
@@ -134,9 +133,9 @@ def test_predict_output(self):
         numpy.array([1, 2, 3]), numpy.array([4, 5, 6]), numpy.array([7, 8, 9])
     ]
     expected_predictions = [
-        api.PredictionResult(numpy.array([1, 2, 3]), 6),
-        api.PredictionResult(numpy.array([4, 5, 6]), 15),
-        api.PredictionResult(numpy.array([7, 8, 9]), 24)
+        base.PredictionResult(numpy.array([1, 2, 3]), 6),

Review Comment:
   WDYT of just importing PredictionResult directly like we do in the pytorch test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org