You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fluss.apache.org by "gnuhpc (via GitHub)" <gi...@apache.org> on 2026/01/17 15:47:50 UTC

Re: [PR] feat(cli): add Fluss CLI with AST-based parsing and 71% test coverage [fluss]

gnuhpc commented on PR #2356:
URL: https://github.com/apache/fluss/pull/2356#issuecomment-3764040264

   ## Update: Squashed Commits + WHERE Filtering
   
   I've force-pushed a clean, squashed commit that includes:
   
   ### Changes in This Update
   1. **Squashed 6 commits → 1 clean commit** for easier review
   2. **Added client-side WHERE filtering** for Log table queries
   3. **Smart column fetching** (SELECT cols ∪ WHERE cols) to minimize network transfer
   4. **10 new filtering tests** (all passing)
   
   ### WHERE Filtering Implementation
   - **Supported operators**: `=`, `<>`, `>`, `<`, `>=`, `<=`, `AND`, `OR`
   - **Architecture**: Server-side projection + client-side filtering
   - **Example flow**:
     ```sql
     SELECT name FROM events WHERE age > 25 AND status = 'active'
     ```
     1. Extract WHERE columns: `[age, status]`
     2. Fetch columns: `[name, age, status]` (optimized)
     3. Server projects these 3 columns
     4. Client filters: `age > 25 AND status = 'active'`
     5. Client projects to: `[name]`
     6. Display: name only
   
   ### Test Results
   - **Total tests**: 201 (10 new filtering tests)
   - **Coverage**: 70.4% instruction, 58.2% line
   - **All tests passing**: ✅
   
   ### Commit Hash
   - **Before**: `95a8e2d0` (6 commits)
   - **After**: `d7a8dd67` (1 squashed commit)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org