You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/02/27 21:42:45 UTC
[jira] [Commented] (FLINK-5921) Adapt time mode indicator functions
return custom data types
[ https://issues.apache.org/jira/browse/FLINK-5921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886575#comment-15886575 ]
ASF GitHub Bot commented on FLINK-5921:
---------------------------------------
GitHub user fhueske opened a pull request:
https://github.com/apache/flink/pull/3425
[FLINK-5921] [table] Add custom data types for rowtime and proctime.
We add a custom data type for the result of the `rowtime()` and `proctime()` marker functions to easier identify the chosen time semantics in when translating window operations.
Both method return a constant timestamp (0L) which is injected during constant expression reduction.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fhueske/flink tableTimeTypes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3425.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3425
----
commit 6cc819b88c408de7b42a968d2a8cdb21ab927ffd
Author: Fabian Hueske <fh...@apache.org>
Date: 2017-02-25T23:28:54Z
[FLINK-5921] [table] Add custom data types for rowtime and proctime.
- proctime() and rowtime() return constont timestamp (0L).
----
> Adapt time mode indicator functions return custom data types
> ------------------------------------------------------------
>
> Key: FLINK-5921
> URL: https://issues.apache.org/jira/browse/FLINK-5921
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Affects Versions: 1.3.0
> Reporter: Fabian Hueske
> Assignee: Fabian Hueske
>
> The functions that indicate event time ({{rowtime()}}) and processing time ({{proctime()}}) are defined to return {{TIMESTAMP}}.
> These functions should be updated to return custom types in order to ease the identification of the time semantics during optimization.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)