[jira] [Commented] (MWRAPPER-65) MavenWrapperDownloader.java ignores the MVNW_REPOURL env

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MWRAPPER-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17554752#comment-17554752 ] 

ASF GitHub Bot commented on MWRAPPER-65:
----------------------------------------

slawekjaranowski merged PR #42:
URL: https://github.com/apache/maven-wrapper/pull/42




> MavenWrapperDownloader.java ignores the MVNW_REPOURL env
> --------------------------------------------------------
>
>                 Key: MWRAPPER-65
>                 URL: https://issues.apache.org/jira/browse/MWRAPPER-65
>             Project: Maven Wrapper
>          Issue Type: Bug
>          Components: Maven Wrapper Scripts
>    Affects Versions: 3.1.0, 3.1.1
>            Reporter: Jorge Solórzano
>            Assignee: Slawomir Jaranowski
>            Priority: Normal
>
> Problem:
> MavenWrapperDownloader.java does not read the environment variable MVNW_REPOURL, so in the case the script has to fallback to the java download version instead of wget/curl, then the behavior will be different and actually might fail as the repository will not be the same.
> Proposal:
> Instead of making MavenWrapperDownloader.java more complex I actually propose the opposite, the MavenWrapperDownloader.java can be simplified by removing code that's already done by the script such as the reading of the property file, the DEFAULT_DOWNLOAD_URL... basically make the MavenWrapperDownloader.java to behave as curl and wget by passing "$wrapperJarPath" "$wrapperUrl" parameters without a lot of the current logic that's already done on the script.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)