You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by zw...@apache.org on 2017/08/30 23:35:26 UTC
[trafficserver] branch master updated: S3_auth:uri(En|De)code()
pass by ref, not val(master)
This is an automated email from the ASF dual-hosted git repository.
zwoop pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git
The following commit(s) were added to refs/heads/master by this push:
new 23a3f24 S3_auth:uri(En|De)code() pass by ref,not val(master)
23a3f24 is described below
commit 23a3f24b8567ad54968943ee4a258c865a866ff6
Author: Gancho Tenev <ga...@apache.com>
AuthorDate: Wed Aug 30 15:43:49 2017 -0700
S3_auth:uri(En|De)code() pass by ref,not val(master)
Changed to pass the input const String by ref instead of value.
---
plugins/s3_auth/aws_auth_v4.cc | 4 ++--
plugins/s3_auth/unit-tests/test_aws_auth_v4.h | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/plugins/s3_auth/aws_auth_v4.cc b/plugins/s3_auth/aws_auth_v4.cc
index 8a624fa..f522118 100644
--- a/plugins/s3_auth/aws_auth_v4.cc
+++ b/plugins/s3_auth/aws_auth_v4.cc
@@ -78,7 +78,7 @@ base16Encode(const char *in, size_t inLen)
* @return encoded string.
*/
String
-uriEncode(const String in, bool isObjectName)
+uriEncode(const String &in, bool isObjectName)
{
std::stringstream result;
@@ -114,7 +114,7 @@ uriEncode(const String in, bool isObjectName)
* @return encoded string.
*/
String
-uriDecode(const String in)
+uriDecode(const String &in)
{
std::string result;
result.reserve(in.length());
diff --git a/plugins/s3_auth/unit-tests/test_aws_auth_v4.h b/plugins/s3_auth/unit-tests/test_aws_auth_v4.h
index 3306b8e..b46274d 100644
--- a/plugins/s3_auth/unit-tests/test_aws_auth_v4.h
+++ b/plugins/s3_auth/unit-tests/test_aws_auth_v4.h
@@ -119,8 +119,8 @@ public:
/* Expose the following methods only to the unit tests */
String base16Encode(const char *in, size_t inLen);
-String uriEncode(const String in, bool isObjectName = false);
-String uriDecode(const String in);
+String uriEncode(const String &in, bool isObjectName = false);
+String uriDecode(const String &in);
String lowercase(const char *in, size_t inLen);
const char *trimWhiteSpaces(const char *in, size_t inLen, size_t &newLen);
--
To stop receiving notification emails like this one, please contact
['"commits@trafficserver.apache.org" <co...@trafficserver.apache.org>'].