You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by ta...@apache.org on 2018/04/03 17:20:43 UTC

[3/5] impala git commit: IMPALA-6445: Test for kudu master address with whitespace

IMPALA-6445: Test for kudu master address with whitespace

A concern was brought up that Impala might not handle kudu master
addresses containing whitespace correctly. Turns out that the Kudu
client takes care of stripping whitespace, so it works, but it would
be good to have a test to ensure it continues to work.

Change-Id: I1857b8dbcb5af66d69f7620368cd3b9b85ae7576
Reviewed-on: http://gerrit.cloudera.org:8080/9876
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Impala Public Jenkins


Project: http://git-wip-us.apache.org/repos/asf/impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/1d0af162
Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/1d0af162
Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/1d0af162

Branch: refs/heads/2.x
Commit: 1d0af16263d120071bbd6c6456955579df0edac4
Parents: 0197b17
Author: Thomas Tauber-Marshall <tm...@cloudera.com>
Authored: Fri Mar 30 14:52:23 2018 -0700
Committer: Impala Public Jenkins <im...@gerrit.cloudera.org>
Committed: Tue Apr 3 00:55:30 2018 +0000

----------------------------------------------------------------------
 .../functional-query/queries/QueryTest/kudu_create.test | 12 ++++++++++++
 1 file changed, 12 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/impala/blob/1d0af162/testdata/workloads/functional-query/queries/QueryTest/kudu_create.test
----------------------------------------------------------------------
diff --git a/testdata/workloads/functional-query/queries/QueryTest/kudu_create.test b/testdata/workloads/functional-query/queries/QueryTest/kudu_create.test
index 24dfdf1..204fc68 100644
--- a/testdata/workloads/functional-query/queries/QueryTest/kudu_create.test
+++ b/testdata/workloads/functional-query/queries/QueryTest/kudu_create.test
@@ -103,6 +103,18 @@ create table tdata_non_existing_host
 Couldn't resolve this master's address bogus.host.name:7051
 ====
 ---- QUERY
+# Valid host with whitespace
+create table tdata_master_addresses_whitespace (id int primary key) stored as kudu
+  tblproperties('kudu.master_addresses' = '  localhost  ')
+---- RESULTS
+====
+---- QUERY
+insert into tdata_master_addresses_whitespace values (0), (1)
+---- DML_RESULTS: tdata_master_addresses_whitespace
+0
+1
+====
+---- QUERY
 # Test that string case is ignored
 create table ignore_column_case (Id int, NAME string, vAlf float, vali bigint,
   primary key (Id, NAME)) PARTITION BY RANGE (PARTITION VALUE = (1, 'Martin'))