You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by kishorvpatil <gi...@git.apache.org> on 2014/11/21 14:45:25 UTC
[GitHub] storm pull request: [STORM-569] Add Configuration to enable/disabl...
GitHub user kishorvpatil opened a pull request:
https://github.com/apache/storm/pull/324
[STORM-569] Add Configuration to enable/disable Bolt's outgoing overflow-buffer
- Added topology level flag `topology.bolts.outgoing.overflow.buffer.enable` - which defaults to `true`
- Create bolt's overflow buffer only if `topology.bolts.outgoing.overflow.buffer.enable` is set
- tested manually using topology with cyclic flow for below scenarios for both
- When set to`false` executors hit live-lock and get restarted as `DisruptorQueue` get full
- When set to `true` executors use overflow buffer to handle spikes and instead of live-lock, they consume more memory.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kishorvpatil/incubator-storm config-obuffer
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/324.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #324
----
commit ccef637701f8dfa88ad2aaa6933549267ece1b0a
Author: Kishor Patil <kp...@yahoo-inc.com>
Date: 2014-11-21T13:34:52Z
Add Configuration to enable/disable Bolt's outgoing overflow-buffer
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-569] Add Configuration to enable/disabl...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/324#issuecomment-64932492
Actually the default in the code is false, not true. But it looks fine to me. +1 I'll merge this into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-569] Add Configuration to enable/disabl...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/324
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---