You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "Dandandan (via GitHub)" <gi...@apache.org> on 2023/06/13 20:45:43 UTC

[GitHub] [arrow-datafusion] Dandandan commented on a diff in pull request #6657: RowAccumulators support generics

Dandandan commented on code in PR #6657:
URL: https://github.com/apache/arrow-datafusion/pull/6657#discussion_r1228679232


##########
datafusion/row/src/writer.rs:
##########
@@ -139,7 +137,8 @@ impl RowWriter {
         self.row_width = self.layout.fixed_part_width();
     }
 
-    #[inline]
+    #[allow(dead_code)]
+    #[inline(always)]
     fn assert_index_valid(&self, idx: usize) {

Review Comment:
   Is this still needed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org