[jira] [Updated] (OAK-4570) Base node states should be reused across generations

["Francesco Mari (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OAK-4570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Francesco Mari updated OAK-4570:
--------------------------------
    Attachment: OAK-4570-01.patch

[^OAK-4570-01.patch] is a potential solution to this issue. I moved the logic to retrieve a compacted {{RecordId}} of a {{NodeState}} into a private method. This method also updates the compaction statistics so, after this change, both node states and their corresponding base node states - if any - will contribute to the statistics.

[~mduerig], [~alex.parvulescu], can you have a look at this?

> Base node states should be reused across generations
> ----------------------------------------------------
>
>                 Key: OAK-4570
>                 URL: https://issues.apache.org/jira/browse/OAK-4570
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: segment-tar
>            Reporter: Francesco Mari
>            Assignee: Francesco Mari
>             Fix For: Segment Tar 0.0.6
>
>         Attachments: OAK-4570-01.patch
>
>
> When committing a {{SegmentNodeBuilder}} obtained from a {{SegmentNodeState}} belonging to a previous generation, base node states should be reused if they were previously compacted.
> This avoids the complete rewrite of templates and property maps. If those records can be obtained from a compacted base node state, they should just be referenced and reused.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)