You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/01/27 10:48:40 UTC

[GitHub] [incubator-shardingsphere] tristaZero opened a new pull request #4091: Using multithread to load tablemetadata from default data source

tristaZero opened a new pull request #4091: Using multithread to load tablemetadata from default data source
URL: https://github.com/apache/incubator-shardingsphere/pull/4091
 
 
   Fixes #3681.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4091: Using multithread to load tablemetadata from default data source

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4091: Using multithread to load tablemetadata from default data source
URL: https://github.com/apache/incubator-shardingsphere/pull/4091#issuecomment-578706063
 
 
   ## Pull Request Test Coverage Report for [Build 1506](https://coveralls.io/builds/28345095)
   
   * **0** of **23**   **(0.0%)**  changed or added relevant lines in **1** file are covered.
   * **2** unchanged lines in **1** file lost coverage.
   * Overall coverage decreased (**-0.02%**) to **66.441%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/sharding/execute/metadata/loader/ShardingTableMetaDataLoader.java](https://coveralls.io/builds/28345095/source?filename=sharding-core%2Fsharding-core-execute%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fexecute%2Fmetadata%2Floader%2FShardingTableMetaDataLoader.java#L80) | 0 | 23 | 0.0%
   <!-- | **Total:** | **0** | **23** | **0.0%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/sharding/execute/metadata/loader/ShardingTableMetaDataLoader.java](https://coveralls.io/builds/28345095/source?filename=sharding-core%2Fsharding-core-execute%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fexecute%2Fmetadata%2Floader%2FShardingTableMetaDataLoader.java#L266) | 2 | 0% |
   <!-- | **Total:** | **2** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28345095/badge)](https://coveralls.io/builds/28345095) |
   | :-- | --: |
   | Change from base [Build 751](https://coveralls.io/builds/28342933): |  -0.02% |
   | Covered Lines: | 10899 |
   | Relevant Lines: | 16404 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [shardingsphere] zebei commented on pull request #4091: Using multithread to load tablemetadata from default data source

Posted by GitBox <gi...@apache.org>.
zebei commented on pull request #4091:
URL: https://github.com/apache/shardingsphere/pull/4091#issuecomment-618780853


   I am using version 4.1.0, but found that the effect of multithread to load tablemetadata is not obvious. 
   When I used it, there were only 200 tables in the database, setting parameter 'max.connections.size.per.query=30' , console print 'Meta data load finished, cost 142547 milliseconds.'
   Personal advice will load the data table to the developer optional configuration items.
    @tristaZero
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-shardingsphere] coveralls commented on issue #4091: Using multithread to load tablemetadata from default data source

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4091: Using multithread to load tablemetadata from default data source
URL: https://github.com/apache/incubator-shardingsphere/pull/4091#issuecomment-578706063
 
 
   ## Pull Request Test Coverage Report for [Build 1507](https://coveralls.io/builds/28344966)
   
   * **0** of **23**   **(0.0%)**  changed or added relevant lines in **1** file are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage decreased (**-0.008%**) to **66.449%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/sharding/execute/metadata/loader/ShardingTableMetaDataLoader.java](https://coveralls.io/builds/28344966/source?filename=sharding-core%2Fsharding-core-execute%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fexecute%2Fmetadata%2Floader%2FShardingTableMetaDataLoader.java#L80) | 0 | 23 | 0.0%
   <!-- | **Total:** | **0** | **23** | **0.0%** | -->
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28344966/badge)](https://coveralls.io/builds/28344966) |
   | :-- | --: |
   | Change from base [Build 751](https://coveralls.io/builds/28342933): |  -0.008% |
   | Covered Lines: | 10899 |
   | Relevant Lines: | 16402 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] SteNicholas merged pull request #4091: Using multithread to load tablemetadata from default data source

Posted by GitBox <gi...@apache.org>.
SteNicholas merged pull request #4091: Using multithread to load tablemetadata from default data source
URL: https://github.com/apache/incubator-shardingsphere/pull/4091
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services