You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/05/07 02:37:11 UTC
[GitHub] [incubator-nuttx] hanyazou opened a new pull request, #6216: Nucleo G474RE board support including USB Full Speed Device
hanyazou opened a new pull request, #6216:
URL: https://github.com/apache/incubator-nuttx/pull/6216
## Summary
This change adds Nucleo G474RE board support including STM32 G474RE USB Full Speed Device driver.
The Nucleo G474RE board support is not so differ from it's base b-g474e-dpow1 discovery kit. The main feature of this contribution is adding USB Full Speed Device driver to STM32 G474RE.
## Impact
Adds new functionality for the STM32 G474.
## Testing
My board with the usbserial configuraion smeems work as a USB CDC ACM device. Type "echo hello > /dev/ttyACM0" on the nsh command prompt to send the bytes to USB host and show the message on terminal emulator on the USB host.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6216: Nucleo G474RE board support including USB Full Speed Device
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6216:
URL: https://github.com/apache/incubator-nuttx/pull/6216#discussion_r867627106
##########
boards/arm/stm32/nucleo-g474re/src/Make.defs:
##########
@@ -0,0 +1,42 @@
+############################################################################
+# boards/arm/stm32/nucleo-g474re/src/Make.defs
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership. The
+# ASF licenses this file to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance with the
+# License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations
+# under the License.
+#
+############################################################################
+
+include $(TOPDIR)/Make.defs
+
+ASRCS =
+CSRCS = stm32_boot.c stm32_bringup.c
+
+ifeq ($(CONFIG_ARCH_LEDS),y)
+CSRCS += stm32_autoleds.c
+else
+CSRCS += stm32_userleds.c
+endif
+
+ifeq ($(CONFIG_BOARDCTL),y)
+CSRCS += stm32_appinit.c
+endif
+
+ifeq ($(CONFIG_USBDEV),y)
+ CSRCS += stm32_usbdev.c
Review Comment:
```suggestion
CSRCS += stm32_usbdev.c
```
Or add 2 spaces in other places
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6216: Nucleo G474RE board support including USB Full Speed Device
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #6216:
URL: https://github.com/apache/incubator-nuttx/pull/6216#issuecomment-1120159670
@hanyazou it's better to merge the last style patch to the first one "stm32 usbfs: Add copy of stm32_usbdev"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6216: Nucleo G474RE board support including USB Full Speed Device
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #6216:
URL: https://github.com/apache/incubator-nuttx/pull/6216#issuecomment-1120178862
> @xiaoxiang781216
>
> merged. does it look good?
The change look good to me, let's wait feedback from other.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6216: Nucleo G474RE board support including USB Full Speed Device
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #6216:
URL: https://github.com/apache/incubator-nuttx/pull/6216
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] hanyazou commented on pull request #6216: Nucleo G474RE board support including USB Full Speed Device
Posted by GitBox <gi...@apache.org>.
hanyazou commented on PR #6216:
URL: https://github.com/apache/incubator-nuttx/pull/6216#issuecomment-1120169360
@xiaoxiang781216
merged. does it look good?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org