You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "justinmclean (via GitHub)" <gi...@apache.org> on 2026/10/08 13:24:45 UTC
[I] cli: consumer-offset set always says consumer for group kinds [iggy]
justinmclean opened a new issue, #4459:
URL: https://github.com/apache/iggy/issues/4459
Split from #4450.
## Problem
`iggy consumer-offset set` always says "consumer", also when `-k consumer-group` or `-k external-group` is used. The text is hard-coded in `explain`, the error context and the success message (`core/cli/src/commands/binary_consumer_offsets/set_consumer_offset.rs:60`, `:71`, `:77`).
`consumer-offset get` already gets this right with `get_consumer_info` (`core/cli/src/commands/binary_consumer_offsets/get_consumer_offset.rs:52`).
## Proposal
Use the same wording as `get_consumer_info` in all three places in `set_consumer_offset.rs`, either by moving it to a shared helper or by adding the same method to `SetConsumerOffsetCmd`.
## Acceptance
- `consumer-offset set -k consumer-group ...` prints "consumer group with ID: ...", and `-k external-group` prints "external group with ID: ...".
- `-k consumer` (the default) prints the same text as today.
- `core/integration/tests/cli/consumer_offset/test_consumer_offset_set_command.rs` covers the consumer and external group kinds and passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] cli: consumer-offset set always says consumer for group kinds [iggy]
Posted by "VedantShuklaaa (via GitHub)" <gi...@apache.org>.
VedantShuklaaa commented on issue #4459:
URL: https://github.com/apache/iggy/issues/4459#issuecomment-6298717102
Hi @SunilKumarPradhan, are you still working on this? It’s been about two weeks since it was assigned. If you’re busy, I’m happy to pick it up. @justinmclean, could you reassign it if Sunil’s no longer on it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] cli: consumer-offset set always says consumer for group kinds [iggy]
Posted by "SunilKumarPradhan (via GitHub)" <gi...@apache.org>.
SunilKumarPradhan commented on issue #4459:
URL: https://github.com/apache/iggy/issues/4459#issuecomment-6306608260
Hi @VedantShuklaaa , I am still working on it will raise PR today. I was midway through implementation, but I got occupied with something else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] cli: consumer-offset set always says consumer for group kinds [iggy]
Posted by "SunilKumarPradhan (via GitHub)" <gi...@apache.org>.
SunilKumarPradhan commented on issue #4459:
URL: https://github.com/apache/iggy/issues/4459#issuecomment-6061564987
Hi @justinmclean I would like to work on this issue , could you please assign it to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] cli: consumer-offset set always says consumer for group kinds [iggy]
Posted by "justinmclean (via GitHub)" <gi...@apache.org>.
justinmclean commented on issue #4459:
URL: https://github.com/apache/iggy/issues/4459#issuecomment-6061737959
All yours
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org