You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/02/05 08:07:46 UTC

[GitHub] [fineract] awasum commented on a change in pull request #1597: Add condition to start TLS (FINERACT-1070)

awasum commented on a change in pull request #1597:
URL: https://github.com/apache/fineract/pull/1597#discussion_r570785195



##########
File path: fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/service/GmailBackedPlatformEmailService.java
##########
@@ -61,6 +64,18 @@ public void sendDefinedEmail(EmailDetail emailDetails) {
         final String authuser = smtpCredentialsData.getUsername();
         final String authpwd = smtpCredentialsData.getPassword();
 
+        LOG.info("Use name: ", smtpCredentialsData.getUsername());
+        LOG.info("Use Password: ", smtpCredentialsData.getPassword());

Review comment:
       Why are you logging password and some critical information ? You can do this in testing on your Dev environment and then remove these lines as critical information is being exposed here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org