You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2015/11/11 21:54:46 UTC
Review Request 40198: Breakout Some Service Masters Into Their Own
Groups To Prevent Auto Skip On Upgrade
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40198/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Nate Cole.
Bugs: AMBARI-13845
https://issues.apache.org/jira/browse/AMBARI-13845
Repository: ambari
Description
-------
The ability to automatically skip failures on skippable components is being expanded to master components incorrectly. This is because those non-core masters are considered to be skippable in general.
The best way to fix this is to adjust the upgrade packs to break out the master components into their own groupings which can be annotated with
{code}
<skippable>true</skippable>
<supports-auto-skip-failure>false</supports-auto-skip-failure>
{code}
This will apply to:
- Ranger
- Spark
- Oozie
- Falcon
{code:title=Example}
<group name="SPARK" title="Spark">
<skippable>true</skippable>
<service-check>false</service-check>
<supports-auto-skip>false</supports-auto-skip>
<service name="SPARK">
<component>SPARK_JOBHISTORYSERVER</component>
</service>
</group>
<group name="SPARK_CLIENTS" title="Spark Clients">
<skippable>true</skippable>
<service name="SPARK">
<component>SPARK_CLIENT</component>
</service>
</group>
{code}
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml a6ff604
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml f0351f8
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml a8a8d89
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 2787468
Diff: https://reviews.apache.org/r/40198/diff/
Testing
-------
Ran through an update and verified that forced failures didn't auto skip non-core masters.
Thanks,
Jonathan Hurley
Re: Review Request 40198: Breakout Some Service Masters Into Their Own
Groups To Prevent Auto Skip On Upgrade
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40198/#review106150
-----------------------------------------------------------
Ship it!
ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml
<https://reviews.apache.org/r/40198/#comment164851>
They can run this step manually, so good call.
- Alejandro Fernandez
On Nov. 11, 2015, 8:54 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40198/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2015, 8:54 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Nate Cole.
>
>
> Bugs: AMBARI-13845
> https://issues.apache.org/jira/browse/AMBARI-13845
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The ability to automatically skip failures on skippable components is being expanded to master components incorrectly. This is because those non-core masters are considered to be skippable in general.
>
> The best way to fix this is to adjust the upgrade packs to break out the master components into their own groupings which can be annotated with
>
> {code}
> <skippable>true</skippable>
> <supports-auto-skip-failure>false</supports-auto-skip-failure>
> {code}
>
> This will apply to:
> - Ranger
> - Spark
> - Oozie
> - Falcon
>
> {code:title=Example}
> <group name="SPARK" title="Spark">
> <skippable>true</skippable>
> <service-check>false</service-check>
> <supports-auto-skip>false</supports-auto-skip>
> <service name="SPARK">
> <component>SPARK_JOBHISTORYSERVER</component>
> </service>
> </group>
>
> <group name="SPARK_CLIENTS" title="Spark Clients">
> <skippable>true</skippable>
> <service name="SPARK">
> <component>SPARK_CLIENT</component>
> </service>
> </group>
> {code}
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml a6ff604
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml f0351f8
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml a8a8d89
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 2787468
>
> Diff: https://reviews.apache.org/r/40198/diff/
>
>
> Testing
> -------
>
> Ran through an update and verified that forced failures didn't auto skip non-core masters.
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 40198: Breakout Some Service Masters Into Their Own
Groups To Prevent Auto Skip On Upgrade
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40198/#review106287
-----------------------------------------------------------
Ship it!
Ship It!
- Jayush Luniya
On Nov. 12, 2015, 3:36 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40198/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2015, 3:36 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Nate Cole.
>
>
> Bugs: AMBARI-13845
> https://issues.apache.org/jira/browse/AMBARI-13845
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The ability to automatically skip failures on skippable components is being expanded to master components incorrectly. This is because those non-core masters are considered to be skippable in general.
>
> The best way to fix this is to adjust the upgrade packs to break out the master components into their own groupings which can be annotated with
>
> {code}
> <skippable>true</skippable>
> <supports-auto-skip-failure>false</supports-auto-skip-failure>
> {code}
>
> This will apply to:
> - Ranger
> - Spark
> - Oozie
> - Falcon
>
> {code:title=Example}
> <group name="SPARK" title="Spark">
> <skippable>true</skippable>
> <service-check>false</service-check>
> <supports-auto-skip>false</supports-auto-skip>
> <service name="SPARK">
> <component>SPARK_JOBHISTORYSERVER</component>
> </service>
> </group>
>
> <group name="SPARK_CLIENTS" title="Spark Clients">
> <skippable>true</skippable>
> <service name="SPARK">
> <component>SPARK_CLIENT</component>
> </service>
> </group>
> {code}
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml 4f286ae
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml 40cb607
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 9a4ddb0
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml a71ad45
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml d318a3a
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml 25620af
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml e419133
>
> Diff: https://reviews.apache.org/r/40198/diff/
>
>
> Testing
> -------
>
> Ran through an update and verified that forced failures didn't auto skip non-core masters.
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 40198: Breakout Some Service Masters Into Their Own
Groups To Prevent Auto Skip On Upgrade
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40198/#review106277
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Nov. 12, 2015, 10:36 a.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40198/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2015, 10:36 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Nate Cole.
>
>
> Bugs: AMBARI-13845
> https://issues.apache.org/jira/browse/AMBARI-13845
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The ability to automatically skip failures on skippable components is being expanded to master components incorrectly. This is because those non-core masters are considered to be skippable in general.
>
> The best way to fix this is to adjust the upgrade packs to break out the master components into their own groupings which can be annotated with
>
> {code}
> <skippable>true</skippable>
> <supports-auto-skip-failure>false</supports-auto-skip-failure>
> {code}
>
> This will apply to:
> - Ranger
> - Spark
> - Oozie
> - Falcon
>
> {code:title=Example}
> <group name="SPARK" title="Spark">
> <skippable>true</skippable>
> <service-check>false</service-check>
> <supports-auto-skip>false</supports-auto-skip>
> <service name="SPARK">
> <component>SPARK_JOBHISTORYSERVER</component>
> </service>
> </group>
>
> <group name="SPARK_CLIENTS" title="Spark Clients">
> <skippable>true</skippable>
> <service name="SPARK">
> <component>SPARK_CLIENT</component>
> </service>
> </group>
> {code}
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml 4f286ae
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml 40cb607
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 9a4ddb0
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml a71ad45
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml d318a3a
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml 25620af
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml e419133
>
> Diff: https://reviews.apache.org/r/40198/diff/
>
>
> Testing
> -------
>
> Ran through an update and verified that forced failures didn't auto skip non-core masters.
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 40198: Breakout Some Service Masters Into Their Own
Groups To Prevent Auto Skip On Upgrade
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40198/
-----------------------------------------------------------
(Updated Nov. 12, 2015, 10:36 a.m.)
Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Nate Cole.
Changes
-------
Updated the express upgrade packs to reflect the changes made to rolling upgrades. Many core masters are now now longer skippable and shutting down completely before hdp-select is not auto-skippable. Broke out clients and slaves into their own groupings (doesn't affect order, just logical groupings)
Bugs: AMBARI-13845
https://issues.apache.org/jira/browse/AMBARI-13845
Repository: ambari
Description
-------
The ability to automatically skip failures on skippable components is being expanded to master components incorrectly. This is because those non-core masters are considered to be skippable in general.
The best way to fix this is to adjust the upgrade packs to break out the master components into their own groupings which can be annotated with
{code}
<skippable>true</skippable>
<supports-auto-skip-failure>false</supports-auto-skip-failure>
{code}
This will apply to:
- Ranger
- Spark
- Oozie
- Falcon
{code:title=Example}
<group name="SPARK" title="Spark">
<skippable>true</skippable>
<service-check>false</service-check>
<supports-auto-skip>false</supports-auto-skip>
<service name="SPARK">
<component>SPARK_JOBHISTORYSERVER</component>
</service>
</group>
<group name="SPARK_CLIENTS" title="Spark Clients">
<skippable>true</skippable>
<service name="SPARK">
<component>SPARK_CLIENT</component>
</service>
</group>
{code}
Diffs (updated)
-----
ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml 4f286ae
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml 40cb607
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 9a4ddb0
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml a71ad45
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml d318a3a
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml 25620af
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml e419133
Diff: https://reviews.apache.org/r/40198/diff/
Testing
-------
Ran through an update and verified that forced failures didn't auto skip non-core masters.
Thanks,
Jonathan Hurley