You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2017/11/17 23:08:26 UTC

[GitHub] pracheer commented on issue #8698: [COREML] Update the json getter

pracheer commented on issue #8698: [COREML] Update the json getter
URL: https://github.com/apache/incubator-mxnet/pull/8698#issuecomment-345390124
 
 
   Looks good to me.
   
   One nitpick suggestion if you think it is useful: can you add some documentation to _get_attrs() with some info on attr/attrs story (like models created w/ which mxnet version will have "attrs" as part of their defn etc)?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services