You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/08/18 15:25:39 UTC

[GitHub] [incubator-kyuubi] zhaomin1423 opened a new pull request, #3270: Change the first letter to uppercase

zhaomin1423 opened a new pull request, #3270:
URL: https://github.com/apache/incubator-kyuubi/pull/3270

   <!--
   Thanks for sending a pull request!
   
   Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
     2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
   -->
   
   ### _Why are the changes needed?_
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you add a feature, you can talk about the use case of it.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   Change the first letter to uppercase.
   
   ### _How was this patch tested?_
   - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
   
   - [ ] Add screenshots for manual tests if appropriate
   
   - [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] zhaomin1423 commented on pull request #3270: Change the first letter to uppercase

Posted by GitBox <gi...@apache.org>.
zhaomin1423 commented on PR #3270:
URL: https://github.com/apache/incubator-kyuubi/pull/3270#issuecomment-1222486361

   > I am fine with it. #3288 is also fixing some parts in docs of authenticaion. Will let you know if the PR3288 merged.
   
   Thanks, closed it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #3270: Change the first letter to uppercase

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on PR #3270:
URL: https://github.com/apache/incubator-kyuubi/pull/3270#issuecomment-1220155654

   are there any other places to fix together?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] zhaomin1423 commented on pull request #3270: Change the first letter to uppercase

Posted by GitBox <gi...@apache.org>.
zhaomin1423 commented on PR #3270:
URL: https://github.com/apache/incubator-kyuubi/pull/3270#issuecomment-1221334185

   > Or let me do it in this PR ? #3288
   
   Thanks, you can do it in a new pr if you like, we can check the typo in the other docs, the pr can be closed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] zhaomin1423 closed pull request #3270: Change the first letter to uppercase

Posted by GitBox <gi...@apache.org>.
zhaomin1423 closed pull request #3270: Change the first letter to uppercase
URL: https://github.com/apache/incubator-kyuubi/pull/3270


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] bowenliang123 commented on pull request #3270: Change the first letter to uppercase

Posted by GitBox <gi...@apache.org>.
bowenliang123 commented on PR #3270:
URL: https://github.com/apache/incubator-kyuubi/pull/3270#issuecomment-1221334757

   I am fine with it.  https://github.com/apache/incubator-kyuubi/pull/3288 is also fixing some parts in docs of authenticaion. Will inform you if the PR3288 merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] bowenliang123 commented on pull request #3270: Change the first letter to uppercase

Posted by GitBox <gi...@apache.org>.
bowenliang123 commented on PR #3270:
URL: https://github.com/apache/incubator-kyuubi/pull/3270#issuecomment-1221333651

   Or let me do it in this PR ? https://github.com/apache/incubator-kyuubi/pull/3288


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org