You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2011/10/20 11:06:14 UTC
DO NOT REPLY [Bug 52062] New: [PATCH] Temporary files delete
https://issues.apache.org/bugzilla/show_bug.cgi?id=52062
Bug #: 52062
Summary: [PATCH] Temporary files delete
Product: POI
Version: 3.8-dev
Platform: PC
OS/Version: Windows XP
Status: NEW
Severity: normal
Priority: P2
Component: SXSSF
AssignedTo: dev@poi.apache.org
ReportedBy: stefan.helfert@googlemail.com
Classification: Unclassified
Created attachment 27823
--> https://issues.apache.org/bugzilla/attachment.cgi?id=27823
Patch File created with ANT patch.xml
The SXSSF API is creating two temporary files during the build process:
poi-sxxsf-sheet.xml
poi-sxxsf-template.xlsx
These two files wont by deleted after the vm got shutted down. (Tested on
Windows XP Prof and Windows 7)
The source of these circumstance is that some streams are not closed and so the
vm couldnt delete these two files.
I created a patch witch fixed this failure.
The two streams according to the two temp files are now closed and the vm can
erase them.
I also fixed the missspelling of the two temp files:
poi-sxxsf -> poi-sxssf
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
DO NOT REPLY [Bug 52062] [PATCH] SXSSF temporary files not deleted
on Windows
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52062
Alex Geller <ag...@4js.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|[PATCH] Temporary files |[PATCH] SXSSF temporary
|delete |files not deleted on
| |Windows
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
DO NOT REPLY [Bug 52062] [PATCH] Temporary files delete
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52062
Stefan Helfert <st...@googlemail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #27823|0 |1
is obsolete| |
Attachment #27824|0 |1
is obsolete| |
--- Comment #2 from Stefan Helfert <st...@googlemail.com> 2011-10-20 11:47:03 UTC ---
Created attachment 27826
--> https://issues.apache.org/bugzilla/attachment.cgi?id=27826
patchfile for fixing temporaryFile error
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
DO NOT REPLY [Bug 52062] [PATCH] Temporary files delete
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52062
Benjamin Bentmann <be...@udo.edu> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #27828|0 |1
is patch| |
Attachment #27828|application/octet-stream |text/plain
mime type| |
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
DO NOT REPLY [Bug 52062] [PATCH] Temporary files delete
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52062
--- Comment #3 from Benjamin Bentmann <be...@udo.edu> 2011-10-20 13:29:40 UTC ---
Created attachment 27828
--> https://issues.apache.org/bugzilla/attachment.cgi?id=27828
patch for issue
Alternative patch that closes resources in finally blocks to ensure files get
closed in case of errors as well.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
DO NOT REPLY [Bug 52062] [PATCH] SXSSF temporary files not deleted
on Windows
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52062
Yegor Kozlov <ye...@dinom.ru> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #6 from Yegor Kozlov <ye...@dinom.ru> 2011-11-07 10:26:20 UTC ---
Applied in r1198693
Thanks,
Yegor
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
DO NOT REPLY [Bug 52062] [PATCH] Temporary files delete
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52062
Stefan Helfert <st...@googlemail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #27823|0 |1
is patch| |
Attachment #27823|application/x-gzip |text/plain
mime type| |
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
DO NOT REPLY [Bug 52062] [PATCH] Temporary files delete
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52062
Benjamin Bentmann <be...@udo.edu> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |benjamin.bentmann@udo.edu
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
DO NOT REPLY [Bug 52062] [PATCH] Temporary files delete
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52062
--- Comment #4 from Alex Geller <ag...@4js.com> 2011-11-04 11:08:20 UTC ---
Created attachment 27894
--> https://issues.apache.org/bugzilla/attachment.cgi?id=27894
Program to reproduce the issue
To find the temporary directory on Windows type %TEMP% into the "Search
programs and files" edit at the bottom of the start menu. On my machine it is
"C:\Users\Alex\AppData\Local\Temp".
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
DO NOT REPLY [Bug 52062] [PATCH] Temporary files delete
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52062
--- Comment #5 from Alex Geller <ag...@4js.com> 2011-11-04 11:10:22 UTC ---
Benjamin's patch looks good to me. I tested it on Windows with the small
program supplied by Stefan (See attachment 27894). The temp files are removed
on both normal and abnormal termination (Hit ^c when the program prompts for
input).
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
DO NOT REPLY [Bug 52062] [PATCH] Temporary files delete
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52062
--- Comment #1 from Stefan Helfert <st...@googlemail.com> 2011-10-20 09:34:50 UTC ---
Created attachment 27824
--> https://issues.apache.org/bugzilla/attachment.cgi?id=27824
TextfileOutput
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org