You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2019/10/03 07:18:46 UTC

[GitHub] [hadoop] adoroszlai opened a new pull request #1580: HDDS-2234. rat.sh fails due to ozone-recon-web/build files

adoroszlai opened a new pull request #1580: HDDS-2234. rat.sh fails due to ozone-recon-web/build files
URL: https://github.com/apache/hadoop/pull/1580
 
 
   ## What changes were proposed in this pull request?
   
   Make RAT check ignore `ozone-recon-web/build` directory.
   
   During `ozone-recon` to `recon` rename ([HDDS-2044](https://issues.apache.org/jira/browse/HDDS-2044)) the directory ignored by RAT was [changed to `recon-web/build`](https://github.com/apache/hadoop/blob/0e026cb0cefcadcfe404cd5d542f081f3b8ab69b/hadoop-ozone/pom.xml#L294), but the real directory is still [`ozone-recon-web`](https://github.com/apache/hadoop/tree/trunk/hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web).
   
   The mismatch is not a problem for CI because it doesn't build anything before the RAT check, so the `build` directory is not present.
   
   https://issues.apache.org/jira/browse/HDDS-2234
   
   ## How was this patch tested?
   
   ```
   $ mvn -f pom.ozone.xml -Dmaven.javadoc.skip=true -DskipTests clean package
   ...
   [INFO] BUILD SUCCESS
   
   $ ls hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/build
   asset-manifest.json
   favicon.ico
   index.html
   manifest.json
   precache-manifest.2d16a2d17952080aea9277dca13a2b39.js
   service-worker.js
   static
   
   $ hadoop-ozone/dev-support/checks/rat.sh
   ...
   [INFO] BUILD SUCCESS
   
   $ echo $?
   0
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org