You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/03/24 12:53:00 UTC

[jira] [Commented] (AIRFLOW-4688) Make scripts Pylint compatible

    [ https://issues.apache.org/jira/browse/AIRFLOW-4688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17065749#comment-17065749 ] 

ASF GitHub Bot commented on AIRFLOW-4688:
-----------------------------------------

gdevanla commented on pull request #7850: [AIRFLOW-4688]: Fix Pylint checkes for modules under scripts
URL: https://github.com/apache/airflow/pull/7850
 
 
   Fix pylint checks. To achieve this, perform minor re-arrangement of code snippets to allow for cleaner code. All checks under `scripts` folder has been addressed in this change.
   
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [ ] Unit tests coverage for changes (not needed for documentation changes)
   - [ x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [ ] Relevant documentation is updated including usage instructions.
   - [ x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Make scripts Pylint compatible
> ------------------------------
>
>                 Key: AIRFLOW-4688
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4688
>             Project: Apache Airflow
>          Issue Type: Sub-task
>          Components: pylint
>    Affects Versions: 2.0.0
>            Reporter: Bas Harenslak
>            Priority: Major
>
> Fix all Pylint messages in scripts. To start; running scripts/ci/ci_pylint.sh on master should produce no messages. (1) Remove the files mentioned in your issue from the blacklist. (2) Run scripts/ci/ci_pylint.sh to see all messages on the no longer blacklisted files. (3) Fix all messages and create PR.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)