You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Gang Tim Liu (JIRA)" <ji...@apache.org> on 2012/06/20 07:54:42 UTC
[jira] [Created] (HIVE-3165) Hive thrift code doesnt generate
quality hashCode()
Gang Tim Liu created HIVE-3165:
----------------------------------
Summary: Hive thrift code doesnt generate quality hashCode()
Key: HIVE-3165
URL: https://issues.apache.org/jira/browse/HIVE-3165
Project: Hive
Issue Type: Bug
Components: Thrift API
Environment: Hive thrift code doesnt generate quality hashCode(). Right now, it all has
@Override
public int hashCode() {
return 0;
}
It will cause all entries go to the same bucket if it's used as hash key.
Reporter: Gang Tim Liu
Assignee: Gang Tim Liu
Priority: Minor
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3165) Hive thrift code doesnt generate
quality hashCode()
Posted by "Gang Tim Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398238#comment-13398238 ]
Gang Tim Liu commented on HIVE-3165:
------------------------------------
Patch is attached to here also.
> Hive thrift code doesnt generate quality hashCode()
> ---------------------------------------------------
>
> Key: HIVE-3165
> URL: https://issues.apache.org/jira/browse/HIVE-3165
> Project: Hive
> Issue Type: Bug
> Components: Thrift API
> Environment: Hive thrift code doesnt generate quality hashCode(). Right now, it all has
> @Override
> public int hashCode() {
> return 0;
> }
> It will cause all entries go to the same bucket if it's used as hash key.
> Reporter: Gang Tim Liu
> Assignee: Gang Tim Liu
> Priority: Minor
> Attachments: Hive-3165.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work started] (HIVE-3165) Hive thrift code doesnt generate
quality hashCode()
Posted by "Gang Tim Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on HIVE-3165 started by Gang Tim Liu.
> Hive thrift code doesnt generate quality hashCode()
> ---------------------------------------------------
>
> Key: HIVE-3165
> URL: https://issues.apache.org/jira/browse/HIVE-3165
> Project: Hive
> Issue Type: Bug
> Components: Thrift API
> Environment: Hive thrift code doesnt generate quality hashCode(). Right now, it all has
> @Override
> public int hashCode() {
> return 0;
> }
> It will cause all entries go to the same bucket if it's used as hash key.
> Reporter: Gang Tim Liu
> Assignee: Gang Tim Liu
> Priority: Minor
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3165) Hive thrift code doesnt generate
quality hashCode()
Posted by "Gang Tim Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398959#comment-13398959 ]
Gang Tim Liu commented on HIVE-3165:
------------------------------------
@Carl, thanks
@Namit, thanks
> Hive thrift code doesnt generate quality hashCode()
> ---------------------------------------------------
>
> Key: HIVE-3165
> URL: https://issues.apache.org/jira/browse/HIVE-3165
> Project: Hive
> Issue Type: Bug
> Components: Thrift API
> Environment: Hive thrift code doesnt generate quality hashCode(). Right now, it all has
> @Override
> public int hashCode() {
> return 0;
> }
> It will cause all entries go to the same bucket if it's used as hash key.
> Reporter: Gang Tim Liu
> Assignee: Gang Tim Liu
> Priority: Minor
> Attachments: Hive-3165.patch, Hive-3165.patch-2
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3165) Hive thrift code doesnt generate
quality hashCode()
Posted by "Gang Tim Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gang Tim Liu updated HIVE-3165:
-------------------------------
Attachment: Hive-3165.patch
> Hive thrift code doesnt generate quality hashCode()
> ---------------------------------------------------
>
> Key: HIVE-3165
> URL: https://issues.apache.org/jira/browse/HIVE-3165
> Project: Hive
> Issue Type: Bug
> Components: Thrift API
> Environment: Hive thrift code doesnt generate quality hashCode(). Right now, it all has
> @Override
> public int hashCode() {
> return 0;
> }
> It will cause all entries go to the same bucket if it's used as hash key.
> Reporter: Gang Tim Liu
> Assignee: Gang Tim Liu
> Priority: Minor
> Attachments: Hive-3165.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3165) Hive thrift code doesnt generate
quality hashCode()
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-3165:
---------------------------------
Status: Open (was: Patch Available)
@Tim: Please see my comment on phabricator. Thanks.
> Hive thrift code doesnt generate quality hashCode()
> ---------------------------------------------------
>
> Key: HIVE-3165
> URL: https://issues.apache.org/jira/browse/HIVE-3165
> Project: Hive
> Issue Type: Bug
> Components: Thrift API
> Environment: Hive thrift code doesnt generate quality hashCode(). Right now, it all has
> @Override
> public int hashCode() {
> return 0;
> }
> It will cause all entries go to the same bucket if it's used as hash key.
> Reporter: Gang Tim Liu
> Assignee: Gang Tim Liu
> Priority: Minor
> Attachments: Hive-3165.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3165) Hive thrift code doesnt generate
quality hashCode()
Posted by "Gang Tim Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398579#comment-13398579 ]
Gang Tim Liu commented on HIVE-3165:
------------------------------------
Test passed. another batch is submitted to https://reviews.facebook.net/D3759. thanks
> Hive thrift code doesnt generate quality hashCode()
> ---------------------------------------------------
>
> Key: HIVE-3165
> URL: https://issues.apache.org/jira/browse/HIVE-3165
> Project: Hive
> Issue Type: Bug
> Components: Thrift API
> Environment: Hive thrift code doesnt generate quality hashCode(). Right now, it all has
> @Override
> public int hashCode() {
> return 0;
> }
> It will cause all entries go to the same bucket if it's used as hash key.
> Reporter: Gang Tim Liu
> Assignee: Gang Tim Liu
> Priority: Minor
> Attachments: Hive-3165.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3165) Hive thrift code doesnt generate
quality hashCode()
Posted by "Gang Tim Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gang Tim Liu updated HIVE-3165:
-------------------------------
Attachment: Hive-3165.patch-2
> Hive thrift code doesnt generate quality hashCode()
> ---------------------------------------------------
>
> Key: HIVE-3165
> URL: https://issues.apache.org/jira/browse/HIVE-3165
> Project: Hive
> Issue Type: Bug
> Components: Thrift API
> Environment: Hive thrift code doesnt generate quality hashCode(). Right now, it all has
> @Override
> public int hashCode() {
> return 0;
> }
> It will cause all entries go to the same bucket if it's used as hash key.
> Reporter: Gang Tim Liu
> Assignee: Gang Tim Liu
> Priority: Minor
> Attachments: Hive-3165.patch, Hive-3165.patch-2
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3165) Hive thrift code doesnt generate
quality hashCode()
Posted by "Gang Tim Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400844#comment-13400844 ]
Gang Tim Liu commented on HIVE-3165:
------------------------------------
@Carl, thank you:)
> Hive thrift code doesnt generate quality hashCode()
> ---------------------------------------------------
>
> Key: HIVE-3165
> URL: https://issues.apache.org/jira/browse/HIVE-3165
> Project: Hive
> Issue Type: Bug
> Components: Thrift API
> Environment: Hive thrift code doesnt generate quality hashCode(). Right now, it all has
> @Override
> public int hashCode() {
> return 0;
> }
> It will cause all entries go to the same bucket if it's used as hash key.
> Reporter: Gang Tim Liu
> Assignee: Gang Tim Liu
> Priority: Minor
> Fix For: 0.10.0
>
> Attachments: Hive-3165.patch, Hive-3165.patch-2
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3165) Hive thrift code doesnt generate
quality hashCode()
Posted by "Gang Tim Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398254#comment-13398254 ]
Gang Tim Liu commented on HIVE-3165:
------------------------------------
@Carl, let me check. thanks a lot
> Hive thrift code doesnt generate quality hashCode()
> ---------------------------------------------------
>
> Key: HIVE-3165
> URL: https://issues.apache.org/jira/browse/HIVE-3165
> Project: Hive
> Issue Type: Bug
> Components: Thrift API
> Environment: Hive thrift code doesnt generate quality hashCode(). Right now, it all has
> @Override
> public int hashCode() {
> return 0;
> }
> It will cause all entries go to the same bucket if it's used as hash key.
> Reporter: Gang Tim Liu
> Assignee: Gang Tim Liu
> Priority: Minor
> Attachments: Hive-3165.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3165) Hive thrift code doesnt generate
quality hashCode()
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-3165:
---------------------------------
Resolution: Fixed
Fix Version/s: 0.10.0
Release Note: (was: Patch has been submitted https://reviews.facebook.net/D3759)
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed to trunk. Thanks Tim!
> Hive thrift code doesnt generate quality hashCode()
> ---------------------------------------------------
>
> Key: HIVE-3165
> URL: https://issues.apache.org/jira/browse/HIVE-3165
> Project: Hive
> Issue Type: Bug
> Components: Thrift API
> Environment: Hive thrift code doesnt generate quality hashCode(). Right now, it all has
> @Override
> public int hashCode() {
> return 0;
> }
> It will cause all entries go to the same bucket if it's used as hash key.
> Reporter: Gang Tim Liu
> Assignee: Gang Tim Liu
> Priority: Minor
> Fix For: 0.10.0
>
> Attachments: Hive-3165.patch, Hive-3165.patch-2
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3165) Hive thrift code doesnt generate
quality hashCode()
Posted by "Gang Tim Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gang Tim Liu updated HIVE-3165:
-------------------------------
Status: Patch Available (was: Open)
A new patch is submitted.
> Hive thrift code doesnt generate quality hashCode()
> ---------------------------------------------------
>
> Key: HIVE-3165
> URL: https://issues.apache.org/jira/browse/HIVE-3165
> Project: Hive
> Issue Type: Bug
> Components: Thrift API
> Environment: Hive thrift code doesnt generate quality hashCode(). Right now, it all has
> @Override
> public int hashCode() {
> return 0;
> }
> It will cause all entries go to the same bucket if it's used as hash key.
> Reporter: Gang Tim Liu
> Assignee: Gang Tim Liu
> Priority: Minor
> Attachments: Hive-3165.patch, Hive-3165.patch-2
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3165) Hive thrift code doesnt generate
quality hashCode()
Posted by "Gang Tim Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gang Tim Liu updated HIVE-3165:
-------------------------------
Release Note: Patch has been submitted https://reviews.facebook.net/D3759
Status: Patch Available (was: In Progress)
> Hive thrift code doesnt generate quality hashCode()
> ---------------------------------------------------
>
> Key: HIVE-3165
> URL: https://issues.apache.org/jira/browse/HIVE-3165
> Project: Hive
> Issue Type: Bug
> Components: Thrift API
> Environment: Hive thrift code doesnt generate quality hashCode(). Right now, it all has
> @Override
> public int hashCode() {
> return 0;
> }
> It will cause all entries go to the same bucket if it's used as hash key.
> Reporter: Gang Tim Liu
> Assignee: Gang Tim Liu
> Priority: Minor
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3165) Hive thrift code doesnt generate
quality hashCode()
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398923#comment-13398923 ]
Carl Steinbach commented on HIVE-3165:
--------------------------------------
@Tim: Changes look good. +1. Will commit if tests pass.
> Hive thrift code doesnt generate quality hashCode()
> ---------------------------------------------------
>
> Key: HIVE-3165
> URL: https://issues.apache.org/jira/browse/HIVE-3165
> Project: Hive
> Issue Type: Bug
> Components: Thrift API
> Environment: Hive thrift code doesnt generate quality hashCode(). Right now, it all has
> @Override
> public int hashCode() {
> return 0;
> }
> It will cause all entries go to the same bucket if it's used as hash key.
> Reporter: Gang Tim Liu
> Assignee: Gang Tim Liu
> Priority: Minor
> Attachments: Hive-3165.patch, Hive-3165.patch-2
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3165) Hive thrift code doesnt generate
quality hashCode()
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398249#comment-13398249 ]
Carl Steinbach commented on HIVE-3165:
--------------------------------------
+1. Will commit if tests pass.
> Hive thrift code doesnt generate quality hashCode()
> ---------------------------------------------------
>
> Key: HIVE-3165
> URL: https://issues.apache.org/jira/browse/HIVE-3165
> Project: Hive
> Issue Type: Bug
> Components: Thrift API
> Environment: Hive thrift code doesnt generate quality hashCode(). Right now, it all has
> @Override
> public int hashCode() {
> return 0;
> }
> It will cause all entries go to the same bucket if it's used as hash key.
> Reporter: Gang Tim Liu
> Assignee: Gang Tim Liu
> Priority: Minor
> Attachments: Hive-3165.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3165) Hive thrift code doesnt generate
quality hashCode()
Posted by "Gang Tim Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398233#comment-13398233 ]
Gang Tim Liu commented on HIVE-3165:
------------------------------------
patch is available for review https://reviews.facebook.net/D3759
> Hive thrift code doesnt generate quality hashCode()
> ---------------------------------------------------
>
> Key: HIVE-3165
> URL: https://issues.apache.org/jira/browse/HIVE-3165
> Project: Hive
> Issue Type: Bug
> Components: Thrift API
> Environment: Hive thrift code doesnt generate quality hashCode(). Right now, it all has
> @Override
> public int hashCode() {
> return 0;
> }
> It will cause all entries go to the same bucket if it's used as hash key.
> Reporter: Gang Tim Liu
> Assignee: Gang Tim Liu
> Priority: Minor
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3165) Hive thrift code doesnt generate
quality hashCode()
Posted by "Gang Tim Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400820#comment-13400820 ]
Gang Tim Liu commented on HIVE-3165:
------------------------------------
@Carl, good Monday. How tests go? what I can do for it. thanks a lot. Tim
> Hive thrift code doesnt generate quality hashCode()
> ---------------------------------------------------
>
> Key: HIVE-3165
> URL: https://issues.apache.org/jira/browse/HIVE-3165
> Project: Hive
> Issue Type: Bug
> Components: Thrift API
> Environment: Hive thrift code doesnt generate quality hashCode(). Right now, it all has
> @Override
> public int hashCode() {
> return 0;
> }
> It will cause all entries go to the same bucket if it's used as hash key.
> Reporter: Gang Tim Liu
> Assignee: Gang Tim Liu
> Priority: Minor
> Attachments: Hive-3165.patch, Hive-3165.patch-2
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3165) Hive thrift code doesnt generate
quality hashCode()
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398907#comment-13398907 ]
Namit Jain commented on HIVE-3165:
----------------------------------
@Carl, I am assuming you will take care of committing this (after reviews/tests etc.)
> Hive thrift code doesnt generate quality hashCode()
> ---------------------------------------------------
>
> Key: HIVE-3165
> URL: https://issues.apache.org/jira/browse/HIVE-3165
> Project: Hive
> Issue Type: Bug
> Components: Thrift API
> Environment: Hive thrift code doesnt generate quality hashCode(). Right now, it all has
> @Override
> public int hashCode() {
> return 0;
> }
> It will cause all entries go to the same bucket if it's used as hash key.
> Reporter: Gang Tim Liu
> Assignee: Gang Tim Liu
> Priority: Minor
> Attachments: Hive-3165.patch, Hive-3165.patch-2
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira