You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by js...@apache.org on 2022/08/30 17:50:47 UTC
[kafka] branch 3.3 updated: MINOR: Add KRaft broker api to protocol docs (#11786)
This is an automated email from the ASF dual-hosted git repository.
jsancio pushed a commit to branch 3.3
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/3.3 by this push:
new 95d124758b MINOR: Add KRaft broker api to protocol docs (#11786)
95d124758b is described below
commit 95d124758b1c67f4a1f09574a5004d4c0f932c71
Author: dengziming <de...@gmail.com>
AuthorDate: Tue Aug 30 14:40:11 2022 +0800
MINOR: Add KRaft broker api to protocol docs (#11786)
Add KRaft broker api to protocol docs
Reviewers: Luke Chen <sh...@gmail.com>
---
.../java/org/apache/kafka/common/protocol/ApiKeys.java | 15 +++++++++++----
.../java/org/apache/kafka/common/protocol/Protocol.java | 2 +-
2 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java b/clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java
index 628c9407cc..f727bd18e5 100644
--- a/clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java
+++ b/clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java
@@ -231,7 +231,7 @@ public enum ApiKeys {
b.append("<th>Name</th>\n");
b.append("<th>Key</th>\n");
b.append("</tr>");
- for (ApiKeys key : zkBrokerApis()) {
+ for (ApiKeys key : clientApis()) {
b.append("<tr>\n");
b.append("<td>");
b.append("<a href=\"#The_Messages_" + key.name + "\">" + key.name + "</a>");
@@ -271,15 +271,22 @@ public enum ApiKeys {
return apisForListener(ApiMessageType.ListenerType.CONTROLLER);
}
+ public static EnumSet<ApiKeys> clientApis() {
+ List<ApiKeys> apis = Arrays.stream(ApiKeys.values())
+ .filter(apiKey -> apiKey.inScope(ApiMessageType.ListenerType.ZK_BROKER) || apiKey.inScope(ApiMessageType.ListenerType.BROKER))
+ .collect(Collectors.toList());
+ return EnumSet.copyOf(apis);
+ }
+
public static EnumSet<ApiKeys> apisForListener(ApiMessageType.ListenerType listener) {
return APIS_BY_LISTENER.get(listener);
}
private static EnumSet<ApiKeys> filterApisForListener(ApiMessageType.ListenerType listener) {
- List<ApiKeys> controllerApis = Arrays.stream(ApiKeys.values())
- .filter(apiKey -> apiKey.messageType.listeners().contains(listener))
+ List<ApiKeys> apis = Arrays.stream(ApiKeys.values())
+ .filter(apiKey -> apiKey.inScope(listener))
.collect(Collectors.toList());
- return EnumSet.copyOf(controllerApis);
+ return EnumSet.copyOf(apis);
}
}
diff --git a/clients/src/main/java/org/apache/kafka/common/protocol/Protocol.java b/clients/src/main/java/org/apache/kafka/common/protocol/Protocol.java
index a75eb0661d..2bc0fc6efe 100644
--- a/clients/src/main/java/org/apache/kafka/common/protocol/Protocol.java
+++ b/clients/src/main/java/org/apache/kafka/common/protocol/Protocol.java
@@ -133,7 +133,7 @@ public class Protocol {
b.append("</pre>\n");
schemaToFieldTableHtml(ResponseHeaderData.SCHEMAS[i], b);
}
- for (ApiKeys key : ApiKeys.zkBrokerApis()) {
+ for (ApiKeys key : ApiKeys.clientApis()) {
// Key
b.append("<h5>");
b.append("<a name=\"The_Messages_" + key.name + "\">");