[jira] [Commented] (OAK-6889) Followup on OAK-6755: fix OSGi component descriptors

["Julian Sedding (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-6889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226938#comment-16226938 ] 

Julian Sedding commented on OAK-6889:
-------------------------------------

Fixed in [r1813889|https://svn.apache.org/r1813889].

Most issues were caused by configuration annotations *not* being referenced in the {{@Activate}} method signature, which is necessary for DS component descriptors to include properties described by the annotation.

From the OSGi Declarative Services Specification Version 1.3, §112.8.3 (emphasis is mine):
{quote}
Properties defined through component property types _used in the signatures of the life cycle methods_.

If any of the referenced component property types have _methods with defaults_, then the generated component description must include a property element for each such method with the property name mapped from the method name, the property type mapped from the method type, and the property value set to the method's default value. 
{quote}

{{AuthorizationConfigurationImpl}} was missing the {{@Designate}} annotation and had a typo in a property name (importBehaviour vs importBehavior).

{{DefaultAuthorizableActionProvider}} (by now moved to {{oak-security-spi}}) needed its option labels and values swapped around.

> Followup on OAK-6755: fix OSGi component descriptors
> ----------------------------------------------------
>
>                 Key: OAK-6889
>                 URL: https://issues.apache.org/jira/browse/OAK-6889
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core, security
>    Affects Versions: 1.7.9
>            Reporter: Julian Sedding
>            Assignee: Julian Sedding
>             Fix For: 1.7.11
>
>
> The fix for OAK-6755 (see also OAK-6741) caused some OSGi metadata to be lost or otherwise incorrect.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)