You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by evis <gi...@git.apache.org> on 2017/06/26 13:50:22 UTC

[GitHub] kafka pull request #3435: KAFKA-4388 Recommended values for converters from ...

GitHub user evis opened a pull request:

    https://github.com/apache/kafka/pull/3435

    KAFKA-4388 Recommended values for converters from plugins

    Questions to reviewers:
    1. Should we cache `converterRecommenders.validValues()`, `SinkConnectorConfig.configDef()` and `SourceConnectorConfig.configDef()` results?
    2. What is appropriate place for testing new `ConnectorConfig.configDef(plugins)` functionality?
    
    cc @ewencp 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/evis/kafka converters_values

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3435.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3435
    
----
commit 069a1ba832f844c20224598c622fa19576b0ba61
Author: Evgeny Veretennikov <ev...@gmail.com>
Date:   2017-06-26T13:44:40Z

    KAFKA-4388 Recommended values for converters from plugins
    
    ConnectorConfig.configDef() takes Plugins parameter now. List of
    recommended values for converters is taken from plugins.converters()

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---