You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2019/12/31 11:28:18 UTC
[GitHub] [incubator-hudi] wangxianghu opened a new pull request #1163:
[HUDI-460] Redo hudi-integ-test log statements using SLF4J
wangxianghu opened a new pull request #1163: [HUDI-460] Redo hudi-integ-test log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1163
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
## What is the purpose of the pull request
*Redo hudi-integ-test log statements using SLF4J*
## Brief change log
*Redo hudi-integ-test log statements using SLF4J*
## Verify this pull request
This pull request is a trivial rework / code cleanup without any test coverage.
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] leesf commented on issue #1163: [HUDI-460] Redo
hudi-integ-test log statements using SLF4J
Posted by GitBox <gi...@apache.org>.
leesf commented on issue #1163: [HUDI-460] Redo hudi-integ-test log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1163#issuecomment-569921071
Thanks for your contribution @wangxianghu , maybe we need to verify the changes with some jobs, e.g. using https://hudi.apache.org/docker_demo.html to avoid jar conflicts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] vinothchandar commented on issue #1163: [HUDI-460]
Redo hudi-integ-test log statements using SLF4J
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on issue #1163: [HUDI-460] Redo hudi-integ-test log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1163#issuecomment-570111514
@leesf @yanghua for all these diffs on slf4j, I think we should establish what testing is good enough, ensure some jobs are tested end-end before we merge? where are we on this front?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] yanghua commented on issue #1163: [HUDI-460] Redo
hudi-integ-test log statements using SLF4J
Posted by GitBox <gi...@apache.org>.
yanghua commented on issue #1163: [HUDI-460] Redo hudi-integ-test log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1163#issuecomment-570125454
> @leesf @yanghua for all these diffs on slf4j, I think we should establish what testing is good enough, ensure some jobs are tested end-end before we merge? where are we on this front?
Reasonable. IMO, it's hard to verify this change via end-to-end test cases or automatic testing. We will require the contributors of the PRs to doing the verification in their local. What's more, we will verify the log print again in our local env.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] lamber-ken commented on issue #1163: [HUDI-460]
Redo hudi-integ-test log statements using SLF4J
Posted by GitBox <gi...@apache.org>.
lamber-ken commented on issue #1163: [HUDI-460] Redo hudi-integ-test log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1163#issuecomment-569914357
👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] wangxianghu commented on issue #1163: [HUDI-460]
Redo hudi-integ-test log statements using SLF4J
Posted by GitBox <gi...@apache.org>.
wangxianghu commented on issue #1163: [HUDI-460] Redo hudi-integ-test log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1163#issuecomment-570130189
@leesf @vinothchandar @yanghua Thank you for your advice, i will verify these changes in my local.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] wangxianghu commented on issue #1163: [HUDI-460]
Redo hudi-integ-test log statements using SLF4J
Posted by GitBox <gi...@apache.org>.
wangxianghu commented on issue #1163: [HUDI-460] Redo hudi-integ-test log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1163#issuecomment-570747956
@leesf Ok, No problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] leesf commented on issue #1163: [HUDI-460] Redo
hudi-integ-test log statements using SLF4J
Posted by GitBox <gi...@apache.org>.
leesf commented on issue #1163: [HUDI-460] Redo hudi-integ-test log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1163#issuecomment-570736469
@wangxianghu Thanks for opening this PR, Could you please reopen and merge this PR to redo-log branch? more context can be found https://lists.apache.org/thread.html/9dc1f3a590413a5224a1a5ad835353e11b2b754e1ec7ad1ca0a55053%40%3Cdev.hudi.apache.org%3E
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] wangxianghu closed pull request #1163: [HUDI-460]
Redo hudi-integ-test log statements using SLF4J
Posted by GitBox <gi...@apache.org>.
wangxianghu closed pull request #1163: [HUDI-460] Redo hudi-integ-test log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1163
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services