Re: [PR] [FLINK-33926][kubernetes]: Allow using job jars in the system classpath in native mode [flink]

["SamBarker (via GitHub)" <gi...@apache.org>]

SamBarker commented on code in PR #25445:
URL: https://github.com/apache/flink/pull/25445#discussion_r1794173964


##########
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesClusterDescriptor.java:
##########
@@ -214,9 +215,12 @@ public ClusterClientProvider<String> deployApplicationCluster(
 
         applicationConfiguration.applyToConfiguration(flinkConfig);
 
-        // No need to do pipelineJars validation if it is a PyFlink job.
+        // No need to do pipelineJars validation if it is a PyFlink job or no jars specified in
+        // pipeline.jars (to use jars in system classpath instead).
         if (!(PackagedProgramUtils.isPython(applicationConfiguration.getApplicationClassName())
-                || PackagedProgramUtils.isPython(applicationConfiguration.getProgramArguments()))) {
+                        || PackagedProgramUtils.isPython(
+                                applicationConfiguration.getProgramArguments()))
+                && flinkConfig.get(PipelineOptions.JARS) != null) {

Review Comment:
   Would it make be useful to push this compound condition to `PackageProgramUtils` as something like `hasClasspath` or `usesSystemClasspath` (with the implied flip to false)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org