You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/10/06 05:15:46 UTC
[GitHub] [hudi] YannByron opened a new pull request #3754: [HUDI-2482] support 'drop partition' sql
YannByron opened a new pull request #3754:
URL: https://github.com/apache/hudi/pull/3754
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3754: [HUDI-2482] support 'drop partition' sql
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3754:
URL: https://github.com/apache/hudi/pull/3754#issuecomment-935480787
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "497ffa10f0e02708acc500487007dea82efb760f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2513",
"triggerID" : "497ffa10f0e02708acc500487007dea82efb760f",
"triggerType" : "PUSH"
}, {
"hash" : "4ffe620924253875d15475125124ac1faef365c6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2528",
"triggerID" : "4ffe620924253875d15475125124ac1faef365c6",
"triggerType" : "PUSH"
}, {
"hash" : "42ea9882efc540dfe36610a5b343b672b1eeaee8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "42ea9882efc540dfe36610a5b343b672b1eeaee8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4ffe620924253875d15475125124ac1faef365c6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2528)
* 42ea9882efc540dfe36610a5b343b672b1eeaee8 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] leesf commented on a change in pull request #3754: [HUDI-2482] support 'drop partition' sql
Posted by GitBox <gi...@apache.org>.
leesf commented on a change in pull request #3754:
URL: https://github.com/apache/hudi/pull/3754#discussion_r724012463
##########
File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/HoodieSqlUtils.scala
##########
@@ -92,7 +93,45 @@ object HoodieSqlUtils extends SparkAdapterSupport {
properties.putAll((spark.sessionState.conf.getAllConfs ++ table.storage.properties).asJava)
HoodieMetadataConfig.newBuilder.fromProperties(properties).build()
}
- FSUtils.getAllPartitionPaths(sparkEngine, metadataConfig, HoodieSqlUtils.getTableLocation(table, spark)).asScala
+ FSUtils.getAllPartitionPaths(sparkEngine, metadataConfig, getTableLocation(table, spark)).asScala
+ }
+
+ /**
+ * This method is used to compatible with the old non-hive-styled partition table.
+ * By default we enable the "hoodie.datasource.write.hive_style_partitioning"
+ * when writing data to hudi table by spark sql by default.
+ * If the exist table is a non-hive-styled partitioned table, we should
+ * disable the "hoodie.datasource.write.hive_style_partitioning" when
+ * merge or update the table. Or else, we will get an incorrect merge result
+ * as the partition path mismatch.
+ */
+ def isNotHiveStyledPartitionTable(partitionPaths: Seq[String], table: CatalogTable): Boolean = {
Review comment:
would rename to `isHiveStylePartitionPartitioning`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3754: [HUDI-2482] support 'drop partition' sql
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3754:
URL: https://github.com/apache/hudi/pull/3754#issuecomment-935480787
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "497ffa10f0e02708acc500487007dea82efb760f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2513",
"triggerID" : "497ffa10f0e02708acc500487007dea82efb760f",
"triggerType" : "PUSH"
}, {
"hash" : "4ffe620924253875d15475125124ac1faef365c6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2528",
"triggerID" : "4ffe620924253875d15475125124ac1faef365c6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 497ffa10f0e02708acc500487007dea82efb760f Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2513)
* 4ffe620924253875d15475125124ac1faef365c6 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2528)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3754: [HUDI-2482] support 'drop partition' sql
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3754:
URL: https://github.com/apache/hudi/pull/3754#issuecomment-935480787
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "497ffa10f0e02708acc500487007dea82efb760f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2513",
"triggerID" : "497ffa10f0e02708acc500487007dea82efb760f",
"triggerType" : "PUSH"
}, {
"hash" : "4ffe620924253875d15475125124ac1faef365c6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4ffe620924253875d15475125124ac1faef365c6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 497ffa10f0e02708acc500487007dea82efb760f Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2513)
* 4ffe620924253875d15475125124ac1faef365c6 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3754: [HUDI-2482] support 'drop partition' sql
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3754:
URL: https://github.com/apache/hudi/pull/3754#issuecomment-935480787
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3754: [HUDI-2482] support 'drop partition' sql
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3754:
URL: https://github.com/apache/hudi/pull/3754#issuecomment-935480787
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3754: [HUDI-2482] support 'drop partition' sql
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3754:
URL: https://github.com/apache/hudi/pull/3754#issuecomment-935480787
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "497ffa10f0e02708acc500487007dea82efb760f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2513",
"triggerID" : "497ffa10f0e02708acc500487007dea82efb760f",
"triggerType" : "PUSH"
}, {
"hash" : "4ffe620924253875d15475125124ac1faef365c6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4ffe620924253875d15475125124ac1faef365c6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 497ffa10f0e02708acc500487007dea82efb760f Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2513)
* 4ffe620924253875d15475125124ac1faef365c6 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3754: [HUDI-2482] support 'drop partition' sql
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3754:
URL: https://github.com/apache/hudi/pull/3754#issuecomment-935480787
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "497ffa10f0e02708acc500487007dea82efb760f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2513",
"triggerID" : "497ffa10f0e02708acc500487007dea82efb760f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 497ffa10f0e02708acc500487007dea82efb760f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2513)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3754: [HUDI-2482] support 'drop partition' sql
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3754:
URL: https://github.com/apache/hudi/pull/3754#issuecomment-935480787
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "497ffa10f0e02708acc500487007dea82efb760f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2513",
"triggerID" : "497ffa10f0e02708acc500487007dea82efb760f",
"triggerType" : "PUSH"
}, {
"hash" : "4ffe620924253875d15475125124ac1faef365c6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2528",
"triggerID" : "4ffe620924253875d15475125124ac1faef365c6",
"triggerType" : "PUSH"
}, {
"hash" : "42ea9882efc540dfe36610a5b343b672b1eeaee8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2542",
"triggerID" : "42ea9882efc540dfe36610a5b343b672b1eeaee8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4ffe620924253875d15475125124ac1faef365c6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2528)
* 42ea9882efc540dfe36610a5b343b672b1eeaee8 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2542)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3754: [HUDI-2482] support 'drop partition' sql
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3754:
URL: https://github.com/apache/hudi/pull/3754#issuecomment-935480787
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "497ffa10f0e02708acc500487007dea82efb760f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2513",
"triggerID" : "497ffa10f0e02708acc500487007dea82efb760f",
"triggerType" : "PUSH"
}, {
"hash" : "4ffe620924253875d15475125124ac1faef365c6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2528",
"triggerID" : "4ffe620924253875d15475125124ac1faef365c6",
"triggerType" : "PUSH"
}, {
"hash" : "42ea9882efc540dfe36610a5b343b672b1eeaee8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2542",
"triggerID" : "42ea9882efc540dfe36610a5b343b672b1eeaee8",
"triggerType" : "PUSH"
}, {
"hash" : "42ea9882efc540dfe36610a5b343b672b1eeaee8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2557",
"triggerID" : "939206082",
"triggerType" : "MANUAL"
}, {
"hash" : "42ea9882efc540dfe36610a5b343b672b1eeaee8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2561",
"triggerID" : "939220103",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 42ea9882efc540dfe36610a5b343b672b1eeaee8 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2542) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2557) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2561)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] YannByron commented on pull request #3754: [HUDI-2482] support 'drop partition' sql
Posted by GitBox <gi...@apache.org>.
YannByron commented on pull request #3754:
URL: https://github.com/apache/hudi/pull/3754#issuecomment-941850211
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3754: [HUDI-2482] support 'drop partition' sql
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3754:
URL: https://github.com/apache/hudi/pull/3754#issuecomment-935480787
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "497ffa10f0e02708acc500487007dea82efb760f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2513",
"triggerID" : "497ffa10f0e02708acc500487007dea82efb760f",
"triggerType" : "PUSH"
}, {
"hash" : "4ffe620924253875d15475125124ac1faef365c6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2528",
"triggerID" : "4ffe620924253875d15475125124ac1faef365c6",
"triggerType" : "PUSH"
}, {
"hash" : "42ea9882efc540dfe36610a5b343b672b1eeaee8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2542",
"triggerID" : "42ea9882efc540dfe36610a5b343b672b1eeaee8",
"triggerType" : "PUSH"
}, {
"hash" : "42ea9882efc540dfe36610a5b343b672b1eeaee8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2557",
"triggerID" : "939206082",
"triggerType" : "MANUAL"
}, {
"hash" : "42ea9882efc540dfe36610a5b343b672b1eeaee8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2561",
"triggerID" : "939220103",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 42ea9882efc540dfe36610a5b343b672b1eeaee8 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2542) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2557) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2561)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] YannByron commented on pull request #3754: [HUDI-2482] support 'drop partition' sql
Posted by GitBox <gi...@apache.org>.
YannByron commented on pull request #3754:
URL: https://github.com/apache/hudi/pull/3754#issuecomment-938550725
@hudi-bot rerun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3754: [HUDI-2482] support 'drop partition' sql
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3754:
URL: https://github.com/apache/hudi/pull/3754#issuecomment-935480787
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "497ffa10f0e02708acc500487007dea82efb760f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2513",
"triggerID" : "497ffa10f0e02708acc500487007dea82efb760f",
"triggerType" : "PUSH"
}, {
"hash" : "4ffe620924253875d15475125124ac1faef365c6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4ffe620924253875d15475125124ac1faef365c6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 497ffa10f0e02708acc500487007dea82efb760f Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2513)
* 4ffe620924253875d15475125124ac1faef365c6 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] leesf commented on a change in pull request #3754: [HUDI-2482] support 'drop partition' sql
Posted by GitBox <gi...@apache.org>.
leesf commented on a change in pull request #3754:
URL: https://github.com/apache/hudi/pull/3754#discussion_r724013236
##########
File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/HoodieSqlUtils.scala
##########
@@ -92,7 +93,45 @@ object HoodieSqlUtils extends SparkAdapterSupport {
properties.putAll((spark.sessionState.conf.getAllConfs ++ table.storage.properties).asJava)
HoodieMetadataConfig.newBuilder.fromProperties(properties).build()
}
- FSUtils.getAllPartitionPaths(sparkEngine, metadataConfig, HoodieSqlUtils.getTableLocation(table, spark)).asScala
+ FSUtils.getAllPartitionPaths(sparkEngine, metadataConfig, getTableLocation(table, spark)).asScala
+ }
+
+ /**
+ * This method is used to compatible with the old non-hive-styled partition table.
+ * By default we enable the "hoodie.datasource.write.hive_style_partitioning"
+ * when writing data to hudi table by spark sql by default.
+ * If the exist table is a non-hive-styled partitioned table, we should
+ * disable the "hoodie.datasource.write.hive_style_partitioning" when
+ * merge or update the table. Or else, we will get an incorrect merge result
+ * as the partition path mismatch.
+ */
+ def isNotHiveStyledPartitionTable(partitionPaths: Seq[String], table: CatalogTable): Boolean = {
+ if (table.partitionColumnNames.nonEmpty) {
+ val isHiveStylePartitionPath = (path: String) => {
+ val fragments = path.split("/")
+ if (fragments.size != table.partitionColumnNames.size) {
+ false
+ } else {
+ fragments.zip(table.partitionColumnNames).forall {
+ case (pathFragment, partitionColumn) => pathFragment.startsWith(s"$partitionColumn=")
+ }
+ }
+ }
+ !partitionPaths.forall(isHiveStylePartitionPath)
+ } else {
+ false
+ }
+ }
+
+ /**
+ * If this table has disable the url encode, spark sql should also disable it when writing to the table.
+ */
+ def isUrlEncodeDisable(partitionPaths: Seq[String], table: CatalogTable): Boolean = {
Review comment:
`isUrlEncodeEnabled` and fix the description please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3754: [HUDI-2482] support 'drop partition' sql
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3754:
URL: https://github.com/apache/hudi/pull/3754#issuecomment-935480787
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "497ffa10f0e02708acc500487007dea82efb760f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2513",
"triggerID" : "497ffa10f0e02708acc500487007dea82efb760f",
"triggerType" : "PUSH"
}, {
"hash" : "4ffe620924253875d15475125124ac1faef365c6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2528",
"triggerID" : "4ffe620924253875d15475125124ac1faef365c6",
"triggerType" : "PUSH"
}, {
"hash" : "42ea9882efc540dfe36610a5b343b672b1eeaee8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2542",
"triggerID" : "42ea9882efc540dfe36610a5b343b672b1eeaee8",
"triggerType" : "PUSH"
}, {
"hash" : "42ea9882efc540dfe36610a5b343b672b1eeaee8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2557",
"triggerID" : "939206082",
"triggerType" : "MANUAL"
}, {
"hash" : "42ea9882efc540dfe36610a5b343b672b1eeaee8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2561",
"triggerID" : "939220103",
"triggerType" : "MANUAL"
}, {
"hash" : "42ea9882efc540dfe36610a5b343b672b1eeaee8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2603",
"triggerID" : "941850211",
"triggerType" : "MANUAL"
}, {
"hash" : "fed6ee27b9f36b17ca668d008f038beccaa1577a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2659",
"triggerID" : "fed6ee27b9f36b17ca668d008f038beccaa1577a",
"triggerType" : "PUSH"
}, {
"hash" : "fed6ee27b9f36b17ca668d008f038beccaa1577a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2676",
"triggerID" : "944889039",
"triggerType" : "MANUAL"
}, {
"hash" : "efe74a2ed328a1c3bcf969efac78afd89472c8de",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2713",
"triggerID" : "efe74a2ed328a1c3bcf969efac78afd89472c8de",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* efe74a2ed328a1c3bcf969efac78afd89472c8de Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2713)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3754: [HUDI-2482] support 'drop partition' sql
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3754:
URL: https://github.com/apache/hudi/pull/3754#issuecomment-935480787
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "497ffa10f0e02708acc500487007dea82efb760f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2513",
"triggerID" : "497ffa10f0e02708acc500487007dea82efb760f",
"triggerType" : "PUSH"
}, {
"hash" : "4ffe620924253875d15475125124ac1faef365c6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4ffe620924253875d15475125124ac1faef365c6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 497ffa10f0e02708acc500487007dea82efb760f Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2513)
* 4ffe620924253875d15475125124ac1faef365c6 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3754: [HUDI-2482] support 'drop partition' sql
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3754:
URL: https://github.com/apache/hudi/pull/3754#issuecomment-935480787
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "497ffa10f0e02708acc500487007dea82efb760f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2513",
"triggerID" : "497ffa10f0e02708acc500487007dea82efb760f",
"triggerType" : "PUSH"
}, {
"hash" : "4ffe620924253875d15475125124ac1faef365c6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2528",
"triggerID" : "4ffe620924253875d15475125124ac1faef365c6",
"triggerType" : "PUSH"
}, {
"hash" : "42ea9882efc540dfe36610a5b343b672b1eeaee8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2542",
"triggerID" : "42ea9882efc540dfe36610a5b343b672b1eeaee8",
"triggerType" : "PUSH"
}, {
"hash" : "42ea9882efc540dfe36610a5b343b672b1eeaee8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2557",
"triggerID" : "939206082",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 42ea9882efc540dfe36610a5b343b672b1eeaee8 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2542) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2557)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] leesf commented on a change in pull request #3754: [HUDI-2482] support 'drop partition' sql
Posted by GitBox <gi...@apache.org>.
leesf commented on a change in pull request #3754:
URL: https://github.com/apache/hudi/pull/3754#discussion_r724012463
##########
File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/HoodieSqlUtils.scala
##########
@@ -92,7 +93,45 @@ object HoodieSqlUtils extends SparkAdapterSupport {
properties.putAll((spark.sessionState.conf.getAllConfs ++ table.storage.properties).asJava)
HoodieMetadataConfig.newBuilder.fromProperties(properties).build()
}
- FSUtils.getAllPartitionPaths(sparkEngine, metadataConfig, HoodieSqlUtils.getTableLocation(table, spark)).asScala
+ FSUtils.getAllPartitionPaths(sparkEngine, metadataConfig, getTableLocation(table, spark)).asScala
+ }
+
+ /**
+ * This method is used to compatible with the old non-hive-styled partition table.
+ * By default we enable the "hoodie.datasource.write.hive_style_partitioning"
+ * when writing data to hudi table by spark sql by default.
+ * If the exist table is a non-hive-styled partitioned table, we should
+ * disable the "hoodie.datasource.write.hive_style_partitioning" when
+ * merge or update the table. Or else, we will get an incorrect merge result
+ * as the partition path mismatch.
+ */
+ def isNotHiveStyledPartitionTable(partitionPaths: Seq[String], table: CatalogTable): Boolean = {
Review comment:
would rename to `isHiveStylePartitionPartitioning`
##########
File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/HoodieSqlUtils.scala
##########
@@ -92,7 +93,45 @@ object HoodieSqlUtils extends SparkAdapterSupport {
properties.putAll((spark.sessionState.conf.getAllConfs ++ table.storage.properties).asJava)
HoodieMetadataConfig.newBuilder.fromProperties(properties).build()
}
- FSUtils.getAllPartitionPaths(sparkEngine, metadataConfig, HoodieSqlUtils.getTableLocation(table, spark)).asScala
+ FSUtils.getAllPartitionPaths(sparkEngine, metadataConfig, getTableLocation(table, spark)).asScala
+ }
+
+ /**
+ * This method is used to compatible with the old non-hive-styled partition table.
+ * By default we enable the "hoodie.datasource.write.hive_style_partitioning"
+ * when writing data to hudi table by spark sql by default.
+ * If the exist table is a non-hive-styled partitioned table, we should
+ * disable the "hoodie.datasource.write.hive_style_partitioning" when
+ * merge or update the table. Or else, we will get an incorrect merge result
+ * as the partition path mismatch.
+ */
+ def isNotHiveStyledPartitionTable(partitionPaths: Seq[String], table: CatalogTable): Boolean = {
+ if (table.partitionColumnNames.nonEmpty) {
+ val isHiveStylePartitionPath = (path: String) => {
+ val fragments = path.split("/")
+ if (fragments.size != table.partitionColumnNames.size) {
+ false
+ } else {
+ fragments.zip(table.partitionColumnNames).forall {
+ case (pathFragment, partitionColumn) => pathFragment.startsWith(s"$partitionColumn=")
+ }
+ }
+ }
+ !partitionPaths.forall(isHiveStylePartitionPath)
+ } else {
+ false
+ }
+ }
+
+ /**
+ * If this table has disable the url encode, spark sql should also disable it when writing to the table.
+ */
+ def isUrlEncodeDisable(partitionPaths: Seq[String], table: CatalogTable): Boolean = {
Review comment:
`isUrlEncodeEnabled` and fix the description please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] leesf commented on pull request #3754: [HUDI-2482] support 'drop partition' sql
Posted by GitBox <gi...@apache.org>.
leesf commented on pull request #3754:
URL: https://github.com/apache/hudi/pull/3754#issuecomment-944889039
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3754: [HUDI-2482] support 'drop partition' sql
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3754:
URL: https://github.com/apache/hudi/pull/3754#issuecomment-935480787
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "497ffa10f0e02708acc500487007dea82efb760f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2513",
"triggerID" : "497ffa10f0e02708acc500487007dea82efb760f",
"triggerType" : "PUSH"
}, {
"hash" : "4ffe620924253875d15475125124ac1faef365c6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2528",
"triggerID" : "4ffe620924253875d15475125124ac1faef365c6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4ffe620924253875d15475125124ac1faef365c6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2528)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3754: [HUDI-2482] support 'drop partition' sql
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3754:
URL: https://github.com/apache/hudi/pull/3754#issuecomment-935480787
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "497ffa10f0e02708acc500487007dea82efb760f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2513",
"triggerID" : "497ffa10f0e02708acc500487007dea82efb760f",
"triggerType" : "PUSH"
}, {
"hash" : "4ffe620924253875d15475125124ac1faef365c6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2528",
"triggerID" : "4ffe620924253875d15475125124ac1faef365c6",
"triggerType" : "PUSH"
}, {
"hash" : "42ea9882efc540dfe36610a5b343b672b1eeaee8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2542",
"triggerID" : "42ea9882efc540dfe36610a5b343b672b1eeaee8",
"triggerType" : "PUSH"
}, {
"hash" : "42ea9882efc540dfe36610a5b343b672b1eeaee8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2557",
"triggerID" : "939206082",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 42ea9882efc540dfe36610a5b343b672b1eeaee8 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2542) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2557)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] YannByron removed a comment on pull request #3754: [HUDI-2482] support 'drop partition' sql
Posted by GitBox <gi...@apache.org>.
YannByron removed a comment on pull request #3754:
URL: https://github.com/apache/hudi/pull/3754#issuecomment-938550725
@hudi-bot rerun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] leesf merged pull request #3754: [HUDI-2482] support 'drop partition' sql
Posted by GitBox <gi...@apache.org>.
leesf merged pull request #3754:
URL: https://github.com/apache/hudi/pull/3754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3754: [HUDI-2482] support 'drop partition' sql
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3754:
URL: https://github.com/apache/hudi/pull/3754#issuecomment-935480787
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "497ffa10f0e02708acc500487007dea82efb760f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2513",
"triggerID" : "497ffa10f0e02708acc500487007dea82efb760f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 497ffa10f0e02708acc500487007dea82efb760f Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2513)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3754: [HUDI-2482] support 'drop partition' sql
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3754:
URL: https://github.com/apache/hudi/pull/3754#issuecomment-935480787
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "497ffa10f0e02708acc500487007dea82efb760f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2513",
"triggerID" : "497ffa10f0e02708acc500487007dea82efb760f",
"triggerType" : "PUSH"
}, {
"hash" : "4ffe620924253875d15475125124ac1faef365c6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2528",
"triggerID" : "4ffe620924253875d15475125124ac1faef365c6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4ffe620924253875d15475125124ac1faef365c6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2528)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] YannByron commented on pull request #3754: [HUDI-2482] support 'drop partition' sql
Posted by GitBox <gi...@apache.org>.
YannByron commented on pull request #3754:
URL: https://github.com/apache/hudi/pull/3754#issuecomment-940595957
@nsivabalan this pr is supporting just the (b), has the same semantic with hive drop-partitions.
The "delete_partitions" operation in hudi currently still has some spaces need to be improved, like not supporting to specify partial partition fields to delete partitions for multi-partitioned table.
I can open another PRs or issues to response these features including that you mentioned above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] YannByron commented on pull request #3754: [HUDI-2482] support 'drop partition' sql
Posted by GitBox <gi...@apache.org>.
YannByron commented on pull request #3754:
URL: https://github.com/apache/hudi/pull/3754#issuecomment-939220103
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3754: [HUDI-2482] support 'drop partition' sql
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3754:
URL: https://github.com/apache/hudi/pull/3754#issuecomment-935480787
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "497ffa10f0e02708acc500487007dea82efb760f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2513",
"triggerID" : "497ffa10f0e02708acc500487007dea82efb760f",
"triggerType" : "PUSH"
}, {
"hash" : "4ffe620924253875d15475125124ac1faef365c6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2528",
"triggerID" : "4ffe620924253875d15475125124ac1faef365c6",
"triggerType" : "PUSH"
}, {
"hash" : "42ea9882efc540dfe36610a5b343b672b1eeaee8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2542",
"triggerID" : "42ea9882efc540dfe36610a5b343b672b1eeaee8",
"triggerType" : "PUSH"
}, {
"hash" : "42ea9882efc540dfe36610a5b343b672b1eeaee8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2557",
"triggerID" : "939206082",
"triggerType" : "MANUAL"
}, {
"hash" : "42ea9882efc540dfe36610a5b343b672b1eeaee8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2561",
"triggerID" : "939220103",
"triggerType" : "MANUAL"
}, {
"hash" : "42ea9882efc540dfe36610a5b343b672b1eeaee8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2603",
"triggerID" : "941850211",
"triggerType" : "MANUAL"
}, {
"hash" : "fed6ee27b9f36b17ca668d008f038beccaa1577a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2659",
"triggerID" : "fed6ee27b9f36b17ca668d008f038beccaa1577a",
"triggerType" : "PUSH"
}, {
"hash" : "fed6ee27b9f36b17ca668d008f038beccaa1577a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2676",
"triggerID" : "944889039",
"triggerType" : "MANUAL"
}, {
"hash" : "efe74a2ed328a1c3bcf969efac78afd89472c8de",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "efe74a2ed328a1c3bcf969efac78afd89472c8de",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fed6ee27b9f36b17ca668d008f038beccaa1577a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2659) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2676)
* efe74a2ed328a1c3bcf969efac78afd89472c8de UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3754: [HUDI-2482] support 'drop partition' sql
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3754:
URL: https://github.com/apache/hudi/pull/3754#issuecomment-935480787
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "497ffa10f0e02708acc500487007dea82efb760f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2513",
"triggerID" : "497ffa10f0e02708acc500487007dea82efb760f",
"triggerType" : "PUSH"
}, {
"hash" : "4ffe620924253875d15475125124ac1faef365c6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2528",
"triggerID" : "4ffe620924253875d15475125124ac1faef365c6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4ffe620924253875d15475125124ac1faef365c6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2528)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3754: [HUDI-2482] support 'drop partition' sql
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3754:
URL: https://github.com/apache/hudi/pull/3754#issuecomment-935480787
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "497ffa10f0e02708acc500487007dea82efb760f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2513",
"triggerID" : "497ffa10f0e02708acc500487007dea82efb760f",
"triggerType" : "PUSH"
}, {
"hash" : "4ffe620924253875d15475125124ac1faef365c6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2528",
"triggerID" : "4ffe620924253875d15475125124ac1faef365c6",
"triggerType" : "PUSH"
}, {
"hash" : "42ea9882efc540dfe36610a5b343b672b1eeaee8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2542",
"triggerID" : "42ea9882efc540dfe36610a5b343b672b1eeaee8",
"triggerType" : "PUSH"
}, {
"hash" : "42ea9882efc540dfe36610a5b343b672b1eeaee8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2557",
"triggerID" : "939206082",
"triggerType" : "MANUAL"
}, {
"hash" : "42ea9882efc540dfe36610a5b343b672b1eeaee8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2561",
"triggerID" : "939220103",
"triggerType" : "MANUAL"
}, {
"hash" : "42ea9882efc540dfe36610a5b343b672b1eeaee8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2603",
"triggerID" : "941850211",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 42ea9882efc540dfe36610a5b343b672b1eeaee8 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2542) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2557) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2561) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2603)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] YannByron commented on pull request #3754: [HUDI-2482] support 'drop partition' sql
Posted by GitBox <gi...@apache.org>.
YannByron commented on pull request #3754:
URL: https://github.com/apache/hudi/pull/3754#issuecomment-941850211
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3754: [HUDI-2482] support 'drop partition' sql
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3754:
URL: https://github.com/apache/hudi/pull/3754#issuecomment-935480787
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "497ffa10f0e02708acc500487007dea82efb760f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2513",
"triggerID" : "497ffa10f0e02708acc500487007dea82efb760f",
"triggerType" : "PUSH"
}, {
"hash" : "4ffe620924253875d15475125124ac1faef365c6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2528",
"triggerID" : "4ffe620924253875d15475125124ac1faef365c6",
"triggerType" : "PUSH"
}, {
"hash" : "42ea9882efc540dfe36610a5b343b672b1eeaee8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2542",
"triggerID" : "42ea9882efc540dfe36610a5b343b672b1eeaee8",
"triggerType" : "PUSH"
}, {
"hash" : "42ea9882efc540dfe36610a5b343b672b1eeaee8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2557",
"triggerID" : "939206082",
"triggerType" : "MANUAL"
}, {
"hash" : "42ea9882efc540dfe36610a5b343b672b1eeaee8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2561",
"triggerID" : "939220103",
"triggerType" : "MANUAL"
}, {
"hash" : "42ea9882efc540dfe36610a5b343b672b1eeaee8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2603",
"triggerID" : "941850211",
"triggerType" : "MANUAL"
}, {
"hash" : "fed6ee27b9f36b17ca668d008f038beccaa1577a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2659",
"triggerID" : "fed6ee27b9f36b17ca668d008f038beccaa1577a",
"triggerType" : "PUSH"
}, {
"hash" : "fed6ee27b9f36b17ca668d008f038beccaa1577a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2676",
"triggerID" : "944889039",
"triggerType" : "MANUAL"
}, {
"hash" : "efe74a2ed328a1c3bcf969efac78afd89472c8de",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2713",
"triggerID" : "efe74a2ed328a1c3bcf969efac78afd89472c8de",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fed6ee27b9f36b17ca668d008f038beccaa1577a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2659) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2676)
* efe74a2ed328a1c3bcf969efac78afd89472c8de Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2713)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3754: [HUDI-2482] support 'drop partition' sql
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3754:
URL: https://github.com/apache/hudi/pull/3754#issuecomment-935480787
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "497ffa10f0e02708acc500487007dea82efb760f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2513",
"triggerID" : "497ffa10f0e02708acc500487007dea82efb760f",
"triggerType" : "PUSH"
}, {
"hash" : "4ffe620924253875d15475125124ac1faef365c6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2528",
"triggerID" : "4ffe620924253875d15475125124ac1faef365c6",
"triggerType" : "PUSH"
}, {
"hash" : "42ea9882efc540dfe36610a5b343b672b1eeaee8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2542",
"triggerID" : "42ea9882efc540dfe36610a5b343b672b1eeaee8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 42ea9882efc540dfe36610a5b343b672b1eeaee8 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2542)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] YannByron commented on a change in pull request #3754: [HUDI-2482] support 'drop partition' sql
Posted by GitBox <gi...@apache.org>.
YannByron commented on a change in pull request #3754:
URL: https://github.com/apache/hudi/pull/3754#discussion_r724849054
##########
File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/HoodieSqlUtils.scala
##########
@@ -92,7 +93,45 @@ object HoodieSqlUtils extends SparkAdapterSupport {
properties.putAll((spark.sessionState.conf.getAllConfs ++ table.storage.properties).asJava)
HoodieMetadataConfig.newBuilder.fromProperties(properties).build()
}
- FSUtils.getAllPartitionPaths(sparkEngine, metadataConfig, HoodieSqlUtils.getTableLocation(table, spark)).asScala
+ FSUtils.getAllPartitionPaths(sparkEngine, metadataConfig, getTableLocation(table, spark)).asScala
+ }
+
+ /**
+ * This method is used to compatible with the old non-hive-styled partition table.
+ * By default we enable the "hoodie.datasource.write.hive_style_partitioning"
+ * when writing data to hudi table by spark sql by default.
+ * If the exist table is a non-hive-styled partitioned table, we should
+ * disable the "hoodie.datasource.write.hive_style_partitioning" when
+ * merge or update the table. Or else, we will get an incorrect merge result
+ * as the partition path mismatch.
+ */
+ def isNotHiveStyledPartitionTable(partitionPaths: Seq[String], table: CatalogTable): Boolean = {
Review comment:
done
##########
File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/HoodieSqlUtils.scala
##########
@@ -92,7 +93,45 @@ object HoodieSqlUtils extends SparkAdapterSupport {
properties.putAll((spark.sessionState.conf.getAllConfs ++ table.storage.properties).asJava)
HoodieMetadataConfig.newBuilder.fromProperties(properties).build()
}
- FSUtils.getAllPartitionPaths(sparkEngine, metadataConfig, HoodieSqlUtils.getTableLocation(table, spark)).asScala
+ FSUtils.getAllPartitionPaths(sparkEngine, metadataConfig, getTableLocation(table, spark)).asScala
+ }
+
+ /**
+ * This method is used to compatible with the old non-hive-styled partition table.
+ * By default we enable the "hoodie.datasource.write.hive_style_partitioning"
+ * when writing data to hudi table by spark sql by default.
+ * If the exist table is a non-hive-styled partitioned table, we should
+ * disable the "hoodie.datasource.write.hive_style_partitioning" when
+ * merge or update the table. Or else, we will get an incorrect merge result
+ * as the partition path mismatch.
+ */
+ def isNotHiveStyledPartitionTable(partitionPaths: Seq[String], table: CatalogTable): Boolean = {
+ if (table.partitionColumnNames.nonEmpty) {
+ val isHiveStylePartitionPath = (path: String) => {
+ val fragments = path.split("/")
+ if (fragments.size != table.partitionColumnNames.size) {
+ false
+ } else {
+ fragments.zip(table.partitionColumnNames).forall {
+ case (pathFragment, partitionColumn) => pathFragment.startsWith(s"$partitionColumn=")
+ }
+ }
+ }
+ !partitionPaths.forall(isHiveStylePartitionPath)
+ } else {
+ false
+ }
+ }
+
+ /**
+ * If this table has disable the url encode, spark sql should also disable it when writing to the table.
+ */
+ def isUrlEncodeDisable(partitionPaths: Seq[String], table: CatalogTable): Boolean = {
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] leesf commented on a change in pull request #3754: [HUDI-2482] support 'drop partition' sql
Posted by GitBox <gi...@apache.org>.
leesf commented on a change in pull request #3754:
URL: https://github.com/apache/hudi/pull/3754#discussion_r729045075
##########
File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/HoodieSqlUtils.scala
##########
@@ -92,7 +93,45 @@ object HoodieSqlUtils extends SparkAdapterSupport {
properties.putAll((spark.sessionState.conf.getAllConfs ++ table.storage.properties).asJava)
HoodieMetadataConfig.newBuilder.fromProperties(properties).build()
}
- FSUtils.getAllPartitionPaths(sparkEngine, metadataConfig, HoodieSqlUtils.getTableLocation(table, spark)).asScala
+ FSUtils.getAllPartitionPaths(sparkEngine, metadataConfig, getTableLocation(table, spark)).asScala
+ }
+
+ /**
+ * This method is used to compatible with the old non-hive-styled partition table.
+ * By default we enable the "hoodie.datasource.write.hive_style_partitioning"
+ * when writing data to hudi table by spark sql by default.
+ * If the exist table is a non-hive-styled partitioned table, we should
+ * disable the "hoodie.datasource.write.hive_style_partitioning" when
+ * merge or update the table. Or else, we will get an incorrect merge result
+ * as the partition path mismatch.
+ */
+ def isHiveStylePartitionPartitioning(partitionPaths: Seq[String], table: CatalogTable): Boolean = {
+ if (table.partitionColumnNames.nonEmpty) {
+ val isHiveStylePartitionPath = (path: String) => {
+ val fragments = path.split("/")
+ if (fragments.size != table.partitionColumnNames.size) {
+ false
+ } else {
+ fragments.zip(table.partitionColumnNames).forall {
+ case (pathFragment, partitionColumn) => pathFragment.startsWith(s"$partitionColumn=")
+ }
+ }
+ }
+ partitionPaths.forall(isHiveStylePartitionPath)
+ } else {
+ true
Review comment:
here means if it is not a partition table, we treat it as hive style partition?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3754: [HUDI-2482] support 'drop partition' sql
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3754:
URL: https://github.com/apache/hudi/pull/3754#issuecomment-935480787
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "497ffa10f0e02708acc500487007dea82efb760f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2513",
"triggerID" : "497ffa10f0e02708acc500487007dea82efb760f",
"triggerType" : "PUSH"
}, {
"hash" : "4ffe620924253875d15475125124ac1faef365c6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2528",
"triggerID" : "4ffe620924253875d15475125124ac1faef365c6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4ffe620924253875d15475125124ac1faef365c6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2528)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] YannByron commented on pull request #3754: [HUDI-2482] support 'drop partition' sql
Posted by GitBox <gi...@apache.org>.
YannByron commented on pull request #3754:
URL: https://github.com/apache/hudi/pull/3754#issuecomment-939206082
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3754: [HUDI-2482] support 'drop partition' sql
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3754:
URL: https://github.com/apache/hudi/pull/3754#issuecomment-935480787
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "497ffa10f0e02708acc500487007dea82efb760f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "497ffa10f0e02708acc500487007dea82efb760f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 497ffa10f0e02708acc500487007dea82efb760f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] leesf commented on a change in pull request #3754: [HUDI-2482] support 'drop partition' sql
Posted by GitBox <gi...@apache.org>.
leesf commented on a change in pull request #3754:
URL: https://github.com/apache/hudi/pull/3754#discussion_r729045601
##########
File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/HoodieSqlUtils.scala
##########
@@ -92,7 +93,45 @@ object HoodieSqlUtils extends SparkAdapterSupport {
properties.putAll((spark.sessionState.conf.getAllConfs ++ table.storage.properties).asJava)
HoodieMetadataConfig.newBuilder.fromProperties(properties).build()
}
- FSUtils.getAllPartitionPaths(sparkEngine, metadataConfig, HoodieSqlUtils.getTableLocation(table, spark)).asScala
+ FSUtils.getAllPartitionPaths(sparkEngine, metadataConfig, getTableLocation(table, spark)).asScala
+ }
+
+ /**
+ * This method is used to compatible with the old non-hive-styled partition table.
+ * By default we enable the "hoodie.datasource.write.hive_style_partitioning"
+ * when writing data to hudi table by spark sql by default.
+ * If the exist table is a non-hive-styled partitioned table, we should
+ * disable the "hoodie.datasource.write.hive_style_partitioning" when
+ * merge or update the table. Or else, we will get an incorrect merge result
+ * as the partition path mismatch.
+ */
+ def isHiveStylePartitionPartitioning(partitionPaths: Seq[String], table: CatalogTable): Boolean = {
Review comment:
rename to isHiveStyledPartitioning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3754: [HUDI-2482] support 'drop partition' sql
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3754:
URL: https://github.com/apache/hudi/pull/3754#issuecomment-935480787
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3754: [HUDI-2482] support 'drop partition' sql
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3754:
URL: https://github.com/apache/hudi/pull/3754#issuecomment-935480787
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "497ffa10f0e02708acc500487007dea82efb760f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2513",
"triggerID" : "497ffa10f0e02708acc500487007dea82efb760f",
"triggerType" : "PUSH"
}, {
"hash" : "4ffe620924253875d15475125124ac1faef365c6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2528",
"triggerID" : "4ffe620924253875d15475125124ac1faef365c6",
"triggerType" : "PUSH"
}, {
"hash" : "42ea9882efc540dfe36610a5b343b672b1eeaee8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2542",
"triggerID" : "42ea9882efc540dfe36610a5b343b672b1eeaee8",
"triggerType" : "PUSH"
}, {
"hash" : "42ea9882efc540dfe36610a5b343b672b1eeaee8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2557",
"triggerID" : "939206082",
"triggerType" : "MANUAL"
}, {
"hash" : "42ea9882efc540dfe36610a5b343b672b1eeaee8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2561",
"triggerID" : "939220103",
"triggerType" : "MANUAL"
}, {
"hash" : "42ea9882efc540dfe36610a5b343b672b1eeaee8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2603",
"triggerID" : "941850211",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 42ea9882efc540dfe36610a5b343b672b1eeaee8 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2542) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2557) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2561) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2603)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org