You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by ke...@apache.org on 2005/10/25 01:31:24 UTC
svn commit: r328190 -
/maven/components/trunk/maven-plugins/maven-checkstyle-plugin/pom.xml
Author: kenney
Date: Mon Oct 24 16:31:22 2005
New Revision: 328190
URL: http://svn.apache.org/viewcvs?rev=328190&view=rev
Log:
Bumped version for reporting-impl since that version correctly excludes
plexus-utils. The group renaming adds both 1.0.2 (old groupId) and 1.0.4
(new groupId) to the compilation classpath, which makes this build fail.
Modified:
maven/components/trunk/maven-plugins/maven-checkstyle-plugin/pom.xml
Modified: maven/components/trunk/maven-plugins/maven-checkstyle-plugin/pom.xml
URL: http://svn.apache.org/viewcvs/maven/components/trunk/maven-plugins/maven-checkstyle-plugin/pom.xml?rev=328190&r1=328189&r2=328190&view=diff
==============================================================================
--- maven/components/trunk/maven-plugins/maven-checkstyle-plugin/pom.xml (original)
+++ maven/components/trunk/maven-plugins/maven-checkstyle-plugin/pom.xml Mon Oct 24 16:31:22 2005
@@ -51,7 +51,7 @@
<dependency>
<groupId>org.apache.maven.reporting</groupId>
<artifactId>maven-reporting-impl</artifactId>
- <version>2.0</version>
+ <version>2.0.1-SNAPSHOT</version>
</dependency>
<dependency>
<groupId>antlr</groupId>
@@ -68,4 +68,4 @@
<version>3.4</version>
</dependency>
</dependencies>
-</project>
\ No newline at end of file
+</project>
Re: svn commit: r328190 -
/maven/components/trunk/maven-plugins/maven-checkstyle-plugin/pom.xml
Posted by Kenney Westerhof <ke...@apache.org>.
On Tue, 25 Oct 2005, Brett Porter wrote:
> Kenney,
>
> Please revert this.
>
> It works in a clean environment, and we can't block
> development of this plugin until 2.0.1.
I really couldn't even bootstrap m2 with this. M2 doesn't see that
plexus:plexus-utils is the same as org.codehaus.plexus:plexus-utils, so
they both end up in the classpath, and the plexus:plexus-utils one (1.0.2)
is first.
> At worst, this should have added the exclusions to the reporting-impl
> dependency rather than updating the version as there is no code change.
An exclusion might work though, but reporting-impl (using doxia that
brings p-u in) might break with the exclusion because of the api-change
(FileUtils.getDefaultExcludes() was moved).
Btw, we're not blocking development, just a release of that plugin. All
the other plugins also depend on the 2.0.1 version of reporting-impl so I
didn't see it as a problem.
There is a code change in the deps.. the plugin won't compile or run with
svn-HEAD.
> All,
>
> Seriously consider before bumping up dependency versions. It means that
> it can't be released until 2.0.1. Certainly for metadata changes, we
> should at least use 2.0-1, 2.0-2 releases which can be done immediately.
That's a good plan. How would we go about it in this case?
> If it does actually depend on 2.0.1 and will have to wait, please
> comment on why it was necessary and add the required <prerequisites> if
> it was a /lib dependency (not the case here).
I'll run a clean bootstrap now (empty ~/.m2/repository/) and if it works
I'll revert, but i spent hours to get it to work using excludes which
didn't take then.
>
> Thanks,
> - Brett
>
> kenney@apache.org wrote:
> > Author: kenney
> > Date: Mon Oct 24 16:31:22 2005
> > New Revision: 328190
> >
> > URL: http://svn.apache.org/viewcvs?rev=328190&view=rev
> > Log:
> > Bumped version for reporting-impl since that version correctly excludes
> > plexus-utils. The group renaming adds both 1.0.2 (old groupId) and 1.0.4
> > (new groupId) to the compilation classpath, which makes this build fail.
> >
> > Modified:
> > maven/components/trunk/maven-plugins/maven-checkstyle-plugin/pom.xml
> >
> > Modified: maven/components/trunk/maven-plugins/maven-checkstyle-plugin/pom.xml
> > URL: http://svn.apache.org/viewcvs/maven/components/trunk/maven-plugins/maven-checkstyle-plugin/pom.xml?rev=328190&r1=328189&r2=328190&view=diff
> > ==============================================================================
> > --- maven/components/trunk/maven-plugins/maven-checkstyle-plugin/pom.xml (original)
> > +++ maven/components/trunk/maven-plugins/maven-checkstyle-plugin/pom.xml Mon Oct 24 16:31:22 2005
> > @@ -51,7 +51,7 @@
> > <dependency>
> > <groupId>org.apache.maven.reporting</groupId>
> > <artifactId>maven-reporting-impl</artifactId>
> > - <version>2.0</version>
> > + <version>2.0.1-SNAPSHOT</version>
> > </dependency>
> > <dependency>
> > <groupId>antlr</groupId>
> > @@ -68,4 +68,4 @@
> > <version>3.4</version>
> > </dependency>
> > </dependencies>
> > -</project>
> > \ No newline at end of file
> > +</project>
> >
> >
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
--
Kenney Westerhof
http://www.neonics.com
GPG public key: http://www.gods.nl/~forge/kenneyw.key
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r328190 - /maven/components/trunk/maven-plugins/maven-checkstyle-plugin/pom.xml
Posted by Brett Porter <br...@apache.org>.
Kenney,
Please revert this. It works in a clean environment, and we can't block
development of this plugin until 2.0.1.
At worst, this should have added the exclusions to the reporting-impl
dependency rather than updating the version as there is no code change.
All,
Seriously consider before bumping up dependency versions. It means that
it can't be released until 2.0.1. Certainly for metadata changes, we
should at least use 2.0-1, 2.0-2 releases which can be done immediately.
If it does actually depend on 2.0.1 and will have to wait, please
comment on why it was necessary and add the required <prerequisites> if
it was a /lib dependency (not the case here).
Thanks,
- Brett
kenney@apache.org wrote:
> Author: kenney
> Date: Mon Oct 24 16:31:22 2005
> New Revision: 328190
>
> URL: http://svn.apache.org/viewcvs?rev=328190&view=rev
> Log:
> Bumped version for reporting-impl since that version correctly excludes
> plexus-utils. The group renaming adds both 1.0.2 (old groupId) and 1.0.4
> (new groupId) to the compilation classpath, which makes this build fail.
>
> Modified:
> maven/components/trunk/maven-plugins/maven-checkstyle-plugin/pom.xml
>
> Modified: maven/components/trunk/maven-plugins/maven-checkstyle-plugin/pom.xml
> URL: http://svn.apache.org/viewcvs/maven/components/trunk/maven-plugins/maven-checkstyle-plugin/pom.xml?rev=328190&r1=328189&r2=328190&view=diff
> ==============================================================================
> --- maven/components/trunk/maven-plugins/maven-checkstyle-plugin/pom.xml (original)
> +++ maven/components/trunk/maven-plugins/maven-checkstyle-plugin/pom.xml Mon Oct 24 16:31:22 2005
> @@ -51,7 +51,7 @@
> <dependency>
> <groupId>org.apache.maven.reporting</groupId>
> <artifactId>maven-reporting-impl</artifactId>
> - <version>2.0</version>
> + <version>2.0.1-SNAPSHOT</version>
> </dependency>
> <dependency>
> <groupId>antlr</groupId>
> @@ -68,4 +68,4 @@
> <version>3.4</version>
> </dependency>
> </dependencies>
> -</project>
> \ No newline at end of file
> +</project>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org