You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/05/30 10:07:47 UTC
[GitHub] [incubator-nuttx] no1wudi opened a new pull request, #6342: arch/risc-v: Unify common source include
no1wudi opened a new pull request, #6342:
URL: https://github.com/apache/incubator-nuttx/pull/6342
## Summary
Follow #6165
## Impact
Refactor only
## Testing
CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6342: arch/risc-v: Unify common source include
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6342:
URL: https://github.com/apache/incubator-nuttx/pull/6342#discussion_r884672871
##########
arch/risc-v/src/common/Make.defs:
##########
@@ -0,0 +1,96 @@
+############################################################################
+# nuttx/arch/risc-v/src/common/Make.defs
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership. The
+# ASF licenses this file to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance with the
+# License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations
+# under the License.
+#
+############################################################################
+
+ifeq ($(CONFIG_BUILD_KERNEL),y)
+STARTUP_OBJS = crt0$(OBJEXT)
+endif
+
+# Specify our general Assembly files
+CMN_ASRCS += riscv_vectors.S riscv_exception_common.S riscv_mhartid.S
+
+# Specify C code within the common directory to be included
+CMN_CSRCS += riscv_initialize.c riscv_swint.c riscv_mtimer.c
+CMN_CSRCS += riscv_allocateheap.c riscv_createstack.c riscv_exit.c
+CMN_CSRCS += riscv_assert.c riscv_blocktask.c riscv_copystate.c riscv_initialstate.c
+CMN_CSRCS += riscv_modifyreg32.c riscv_puts.c
+CMN_CSRCS += riscv_releasepending.c riscv_reprioritizertr.c
+CMN_CSRCS += riscv_releasestack.c riscv_stackframe.c riscv_schedulesigaction.c
+CMN_CSRCS += riscv_sigdeliver.c riscv_unblocktask.c riscv_usestack.c
+CMN_CSRCS += riscv_idle.c riscv_tcbinfo.c riscv_cpuidlestack.c
+CMN_CSRCS += riscv_exception.c riscv_getnewintctx.c riscv_doirq.c
+CMN_CSRCS += riscv_saveusercontext.c
+
+ifeq ($(CONFIG_SMP), y)
Review Comment:
```suggestion
ifeq ($(CONFIG_SMP),y)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #6342: arch/risc-v: Unify common source include
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on PR #6342:
URL: https://github.com/apache/incubator-nuttx/pull/6342#issuecomment-1141527670
```
riscv64-unknown-elf-ld: /Users/runner/work/incubator-nuttx/incubator-nuttx/sources/nuttx/staging/libarch.a(riscv_exception.o): in function `riscv_exception_attach':
/Users/runner/work/incubator-nuttx/incubator-nuttx/sources/nuttx/arch/risc-v/src/common/riscv_exception.c:112: undefined reference to `riscv_misaligned'
riscv64-unknown-elf-ld: /Users/runner/work/incubator-nuttx/incubator-nuttx/sources/nuttx/arch/risc-v/src/common/riscv_exception.c:112: undefined reference to `riscv_misaligned'
riscv64-unknown-elf-ld: /Users/runner/work/incubator-nuttx/incubator-nuttx/sources/nuttx/arch/risc-v/src/common/riscv_exception.c:113: undefined reference to `riscv_misaligned'
make[1]: *** [nuttx] Error 1
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko merged pull request #6342: arch/risc-v: Unify common source include
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged PR #6342:
URL: https://github.com/apache/incubator-nuttx/pull/6342
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org