[GitHub] [curator] shayshim commented on a change in pull request #338: [CURATOR-549] Prep for Persistent Watchers by moving to ZK 3.6.0

[GitBox <gi...@apache.org>]

shayshim commented on a change in pull request #338: [CURATOR-549] Prep for Persistent Watchers by moving to ZK 3.6.0
URL: https://github.com/apache/curator/pull/338#discussion_r344514913
 
 

 ##########
 File path: curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java
 ##########
 @@ -620,6 +621,15 @@ ZooKeeper getZooKeeper() throws Exception
         return client.getZooKeeper();
     }
 
+    Object getZooKeeperAdmin() throws Exception
 
 Review comment:
   If we return client.getZooKeeper(), just like in getZooKeeper(), then this method seems unneeded to me. Clients should call getZooKeeper() and cast to ZooKeeperAdmin if they need (like in ReconfigBuilderImpl). 
   You also could promise in its javadoc to return ZooKeeperAdmin for versions 3.5 and up.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services