You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/08/15 10:15:05 UTC
[GitHub] [airflow] Fokko commented on a change in pull request #5786:
[AIRFLOW-5170] Fix encoding pragmas,
consistent licences for python files and related pylint fixes
Fokko commented on a change in pull request #5786: [AIRFLOW-5170] Fix encoding pragmas, consistent licences for python files and related pylint fixes
URL: https://github.com/apache/airflow/pull/5786#discussion_r314250523
##########
File path: airflow/contrib/hooks/bigquery_hook.py
##########
@@ -1,5 +1,4 @@
-# -*- coding: utf-8 -*- # pylint: disable=too-many-lines
-#
+# -*- coding: utf-8 -*-
Review comment:
While we're at it, I think we should be consistent with this one as well:
```
# -*- coding: utf-8 -*-
# Licensed to the Apache Software Foundation (ASF) under one
```
or:
```
# -*- coding: utf-8 -*-
#
# Licensed to the Apache Software Foundation (ASF) under one
```
I prefer the latter :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services