You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "matthiasblaesing (via GitHub)" <gi...@apache.org> on 2024/09/04 19:30:37 UTC
[PR] Update Typescript Language Server to 4.4.3 [netbeans]
matthiasblaesing opened a new pull request, #7732:
URL: https://github.com/apache/netbeans/pull/7732
- Update typescript to 5.5.4 (implies minimal node version 10)
- Update typescript-language-server to 5.5.4
- Add PublishDiagnosticsCapabilities to declared capabilities
- Added handling of SematicHighlighting for tokenTypeId -1: Assume this means "only consider modifier"
- Document update procedure
- Add @todo for handling mapping mimetype -> languageId
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update Typescript Language Server to 4.4.3 [netbeans]
Posted by "Chris2011 (via GitHub)" <gi...@apache.org>.
Chris2011 commented on PR #7732:
URL: https://github.com/apache/netbeans/pull/7732#issuecomment-2331661358
Sure, will do today and will let you know. Thx :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update Typescript Language Server to 4.4.3 [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #7732:
URL: https://github.com/apache/netbeans/pull/7732#issuecomment-2368925661
@Chris2011 thanks for taking the time to test, reproduce and recheck!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update Typescript Language Server to 4.4.3 [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #7732:
URL: https://github.com/apache/netbeans/pull/7732#discussion_r1919651117
##########
webcommon/typescript.editor/external/binaries-list:
##########
@@ -15,22 +15,5 @@
# specific language governing permissions and limitations
# under the License.
-EEBA3C1183C93B924F59F99D18143C6854855140 command-exists-1.2.6.zip
-D54E3334BE790F2AF65068B404E069AB7158795B commander-2.20.3.zip
-9545FC9061706C762E852F3D4DA3164EDFD96FE1 crypto-random-string-1.0.0.zip
-97705D5EE06EDD1981369ABD129EAC37C25DC5D5 fs-extra-7.0.1.zip
-DB515913528F8F8C48678FEF88697875ADEF133C graceful-fs-4.2.6.zip
-5A908B2D235A118C634F58E228B3992488847A98 jsonfile-4.0.0.zip
-F176424C20EE59996C503BAEBF18D2C70F184840 p-debounce-1.0.0.zip
-C553EC2693BF9B1E942E8DDFFBF6A591FE753F84 temp-dir-1.0.0.zip
-5C31F32D7D10CAB54F13408C64B42B62D51796EE tempy-0.2.1.zip
-B36AEE158BE444FD89CA51DBE61EC2BA4E7653AA typescript-4.1.4.zip
-719BC3E8A6F6DDA67A7E9642B498386D6CAD022A typescript-language-server-0.5.1.zip
-80FD5AA5DF32BE742BE353E5C4784868ED7D0D38 unique-string-1.0.0.zip
-BE24C4558E26E8B7CDEAFF2F9AE70D3BB5BEB0A8 universalify-0.1.2.zip
-09CF27455281E6C4FAA30571125D4F6E42EC3D5D vscode-jsonrpc-6.0.0.zip
-06B648FCE1A5B1FBC0306C30DB593AAAF6989A52 vscode-languageserver-5.3.0-next.10.zip
-6065994D322B86EB06D642F96F16018774E8440F vscode-languageserver-protocol-3.16.0.zip
-BC9B7B5E8243882E6AFC2D26D1008EF3F960F22F vscode-languageserver-types-3.16.0.zip
-191490D1923C11D2D7BFDB8F86CEB61567CA62A0 vscode-textbuffer-1.0.0.zip
-75BF5DA9B1BFDFD1A85E0A67E86504B7E05482D8 vscode-uri-1.0.8.zip
+48304CC9611D4F3B4ACD5A6ABB88689913BFA7A0 https://doppel-helix.eu/test-typescript-update/48304CC9611D4F3B4ACD5A6ABB88689913BFA7A0-typescript-5.6.2.zip typescript-5.6.2.zip
+6895F0456E4B0FE3D857AA7D3F399932A026D060 https://doppel-helix.eu/test-typescript-update/typescript-language-server-4.3.3.zip typescript-language-server-4.3.3.zip
Review Comment:
@matthiasblaesing was this host intended? `test-typescrpt-update` sounds like a temporary location (probably meant to be moved to osuosl!).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update Typescript Language Server to 4.4.3 [netbeans]
Posted by "Chris2011 (via GitHub)" <gi...@apache.org>.
Chris2011 commented on PR #7732:
URL: https://github.com/apache/netbeans/pull/7732#issuecomment-2352644675
I read the news, that TypeScript 5.6 was released. I dunno whether this will fix the bug or not, but is it maybe possible to handle TS as maven too? So we bundle typescript hard to NetBeans and everytime an update was released we need to update it. Afaik maven is bundled with NetBeans, but you can choose your own version of it. Similar to bower, grunt, gulp, node, karma etc. It is just an idea but could be part of a different PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update Typescript Language Server to 4.4.3 [netbeans]
Posted by "Chris2011 (via GitHub)" <gi...@apache.org>.
Chris2011 commented on PR #7732:
URL: https://github.com/apache/netbeans/pull/7732#issuecomment-2359232703
So it seems, that the second issue is gone, the first still exists. I created a screen capture, hope it helps. It happens, when you first open the code completion, than delete a character or sometimes a whole word.
https://github.com/user-attachments/assets/fffe8cbd-c809-4078-9ace-f1c95ecef8f5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update Typescript Language Server to 4.4.3 [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #7732:
URL: https://github.com/apache/netbeans/pull/7732#issuecomment-2353748350
@lahodaj I updated the `prepare` project to also cover the renamed `ThirdPartyNoticeText.txt` file. Both variants are now covered.
@Chris2011 I updated typescript to 5.6.2 and I did not see a change. However, I think the problem was, that `DiagnosticFixList` called into the typescript lsp with an out of bounds index. This is now guarded and it seems to fix the problem. Even if the problem resurfaces, the problem is logged with a lower level, only being reported in the messages.log, but not on the GUI.
Could you please both have another look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update Typescript Language Server to 4.4.3 [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #7732:
URL: https://github.com/apache/netbeans/pull/7732#issuecomment-2365296573
@Chris2011 thank you. Indeed I was able to reproduce. The issue is not as easily fixable as [110c7db](https://github.com/apache/netbeans/pull/7732/commits/110c7dba8ac550a38b312031febecbb1005e2f0c) and I also think the server should be able to handle delayed resolve of completion and not raise an exception. As I can't prevent it, I only reduced log level to INFO, so problem is logged, but user can continue working.
For me this fixes the problem. Can you confirm?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update Typescript Language Server to 4.4.3 [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #7732:
URL: https://github.com/apache/netbeans/pull/7732#discussion_r1920531373
##########
webcommon/typescript.editor/external/binaries-list:
##########
@@ -15,22 +15,5 @@
# specific language governing permissions and limitations
# under the License.
-EEBA3C1183C93B924F59F99D18143C6854855140 command-exists-1.2.6.zip
-D54E3334BE790F2AF65068B404E069AB7158795B commander-2.20.3.zip
-9545FC9061706C762E852F3D4DA3164EDFD96FE1 crypto-random-string-1.0.0.zip
-97705D5EE06EDD1981369ABD129EAC37C25DC5D5 fs-extra-7.0.1.zip
-DB515913528F8F8C48678FEF88697875ADEF133C graceful-fs-4.2.6.zip
-5A908B2D235A118C634F58E228B3992488847A98 jsonfile-4.0.0.zip
-F176424C20EE59996C503BAEBF18D2C70F184840 p-debounce-1.0.0.zip
-C553EC2693BF9B1E942E8DDFFBF6A591FE753F84 temp-dir-1.0.0.zip
-5C31F32D7D10CAB54F13408C64B42B62D51796EE tempy-0.2.1.zip
-B36AEE158BE444FD89CA51DBE61EC2BA4E7653AA typescript-4.1.4.zip
-719BC3E8A6F6DDA67A7E9642B498386D6CAD022A typescript-language-server-0.5.1.zip
-80FD5AA5DF32BE742BE353E5C4784868ED7D0D38 unique-string-1.0.0.zip
-BE24C4558E26E8B7CDEAFF2F9AE70D3BB5BEB0A8 universalify-0.1.2.zip
-09CF27455281E6C4FAA30571125D4F6E42EC3D5D vscode-jsonrpc-6.0.0.zip
-06B648FCE1A5B1FBC0306C30DB593AAAF6989A52 vscode-languageserver-5.3.0-next.10.zip
-6065994D322B86EB06D642F96F16018774E8440F vscode-languageserver-protocol-3.16.0.zip
-BC9B7B5E8243882E6AFC2D26D1008EF3F960F22F vscode-languageserver-types-3.16.0.zip
-191490D1923C11D2D7BFDB8F86CEB61567CA62A0 vscode-textbuffer-1.0.0.zip
-75BF5DA9B1BFDFD1A85E0A67E86504B7E05482D8 vscode-uri-1.0.8.zip
+48304CC9611D4F3B4ACD5A6ABB88689913BFA7A0 https://doppel-helix.eu/test-typescript-update/48304CC9611D4F3B4ACD5A6ABB88689913BFA7A0-typescript-5.6.2.zip typescript-5.6.2.zip
+6895F0456E4B0FE3D857AA7D3F399932A026D060 https://doppel-helix.eu/test-typescript-update/typescript-language-server-4.3.3.zip typescript-language-server-4.3.3.zip
Review Comment:
@matthiasblaesing the files seem to be offline now :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update Typescript Language Server to 4.4.3 [netbeans]
Posted by "Chris2011 (via GitHub)" <gi...@apache.org>.
Chris2011 commented on PR #7732:
URL: https://github.com/apache/netbeans/pull/7732#issuecomment-2359185715
@matthiasblaesing FYI will do it today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update Typescript Language Server to 4.4.3 [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #7732:
URL: https://github.com/apache/netbeans/pull/7732#discussion_r1919651117
##########
webcommon/typescript.editor/external/binaries-list:
##########
@@ -15,22 +15,5 @@
# specific language governing permissions and limitations
# under the License.
-EEBA3C1183C93B924F59F99D18143C6854855140 command-exists-1.2.6.zip
-D54E3334BE790F2AF65068B404E069AB7158795B commander-2.20.3.zip
-9545FC9061706C762E852F3D4DA3164EDFD96FE1 crypto-random-string-1.0.0.zip
-97705D5EE06EDD1981369ABD129EAC37C25DC5D5 fs-extra-7.0.1.zip
-DB515913528F8F8C48678FEF88697875ADEF133C graceful-fs-4.2.6.zip
-5A908B2D235A118C634F58E228B3992488847A98 jsonfile-4.0.0.zip
-F176424C20EE59996C503BAEBF18D2C70F184840 p-debounce-1.0.0.zip
-C553EC2693BF9B1E942E8DDFFBF6A591FE753F84 temp-dir-1.0.0.zip
-5C31F32D7D10CAB54F13408C64B42B62D51796EE tempy-0.2.1.zip
-B36AEE158BE444FD89CA51DBE61EC2BA4E7653AA typescript-4.1.4.zip
-719BC3E8A6F6DDA67A7E9642B498386D6CAD022A typescript-language-server-0.5.1.zip
-80FD5AA5DF32BE742BE353E5C4784868ED7D0D38 unique-string-1.0.0.zip
-BE24C4558E26E8B7CDEAFF2F9AE70D3BB5BEB0A8 universalify-0.1.2.zip
-09CF27455281E6C4FAA30571125D4F6E42EC3D5D vscode-jsonrpc-6.0.0.zip
-06B648FCE1A5B1FBC0306C30DB593AAAF6989A52 vscode-languageserver-5.3.0-next.10.zip
-6065994D322B86EB06D642F96F16018774E8440F vscode-languageserver-protocol-3.16.0.zip
-BC9B7B5E8243882E6AFC2D26D1008EF3F960F22F vscode-languageserver-types-3.16.0.zip
-191490D1923C11D2D7BFDB8F86CEB61567CA62A0 vscode-textbuffer-1.0.0.zip
-75BF5DA9B1BFDFD1A85E0A67E86504B7E05482D8 vscode-uri-1.0.8.zip
+48304CC9611D4F3B4ACD5A6ABB88689913BFA7A0 https://doppel-helix.eu/test-typescript-update/48304CC9611D4F3B4ACD5A6ABB88689913BFA7A0-typescript-5.6.2.zip typescript-5.6.2.zip
+6895F0456E4B0FE3D857AA7D3F399932A026D060 https://doppel-helix.eu/test-typescript-update/typescript-language-server-4.3.3.zip typescript-language-server-4.3.3.zip
Review Comment:
@matthiasblaesing was this host intended? `test-typescrpt-update` sounds like a temporary location.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update Typescript Language Server to 4.4.3 [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #7732:
URL: https://github.com/apache/netbeans/pull/7732#issuecomment-2334477588
@Chris2011 thanks for the test. Could reproduce the second problem, but failed for the first one. I asked google for similar problems and it seems the typescript-language-server is regressing. Similar reports can be found for Webstorm/IntelliJ.
There were indications, that typescript 5.5.X might be the problem, but downgrading to 5.4.X did not help.
I have to see whether manually patching the current lsp integration to be runnable with up-to-date node versions or whether there is a "known-good" set of typescript and node.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update Typescript Language Server to 4.4.3 [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on code in PR #7732:
URL: https://github.com/apache/netbeans/pull/7732#discussion_r1747708662
##########
webcommon/typescript.editor/external/typescript-5.5.4-license.txt:
##########
@@ -1,6 +1,6 @@
Name: typescript
Description: TypeScript is a language for application scale JavaScript development
-Version: 4.1.4
+Version: 5.5.4
Review Comment:
Valid point. I admit, I did not check, on the other hand, the relevant file would be NOTICE, but so be it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update Typescript Language Server to 4.4.3 [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #7732:
URL: https://github.com/apache/netbeans/pull/7732#issuecomment-2417622944
I intent to merge this next saturday. Typescript LSP fails to run on windows with node LTS and that is fixed by this. The change request was addressed, I ran with this the last weeks, so I think this is good to be merged.
If anyone wants to object, please do so now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update Typescript Language Server to 4.4.3 [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #7732:
URL: https://github.com/apache/netbeans/pull/7732#issuecomment-2402927396
I cleaned up the history. @jlahoda you requested changes. Could you please check if they were addressed? I'd like to get this in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update Typescript Language Server to 4.4.3 [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on code in PR #7732:
URL: https://github.com/apache/netbeans/pull/7732#discussion_r1920644114
##########
webcommon/typescript.editor/external/binaries-list:
##########
@@ -15,22 +15,5 @@
# specific language governing permissions and limitations
# under the License.
-EEBA3C1183C93B924F59F99D18143C6854855140 command-exists-1.2.6.zip
-D54E3334BE790F2AF65068B404E069AB7158795B commander-2.20.3.zip
-9545FC9061706C762E852F3D4DA3164EDFD96FE1 crypto-random-string-1.0.0.zip
-97705D5EE06EDD1981369ABD129EAC37C25DC5D5 fs-extra-7.0.1.zip
-DB515913528F8F8C48678FEF88697875ADEF133C graceful-fs-4.2.6.zip
-5A908B2D235A118C634F58E228B3992488847A98 jsonfile-4.0.0.zip
-F176424C20EE59996C503BAEBF18D2C70F184840 p-debounce-1.0.0.zip
-C553EC2693BF9B1E942E8DDFFBF6A591FE753F84 temp-dir-1.0.0.zip
-5C31F32D7D10CAB54F13408C64B42B62D51796EE tempy-0.2.1.zip
-B36AEE158BE444FD89CA51DBE61EC2BA4E7653AA typescript-4.1.4.zip
-719BC3E8A6F6DDA67A7E9642B498386D6CAD022A typescript-language-server-0.5.1.zip
-80FD5AA5DF32BE742BE353E5C4784868ED7D0D38 unique-string-1.0.0.zip
-BE24C4558E26E8B7CDEAFF2F9AE70D3BB5BEB0A8 universalify-0.1.2.zip
-09CF27455281E6C4FAA30571125D4F6E42EC3D5D vscode-jsonrpc-6.0.0.zip
-06B648FCE1A5B1FBC0306C30DB593AAAF6989A52 vscode-languageserver-5.3.0-next.10.zip
-6065994D322B86EB06D642F96F16018774E8440F vscode-languageserver-protocol-3.16.0.zip
-BC9B7B5E8243882E6AFC2D26D1008EF3F960F22F vscode-languageserver-types-3.16.0.zip
-191490D1923C11D2D7BFDB8F86CEB61567CA62A0 vscode-textbuffer-1.0.0.zip
-75BF5DA9B1BFDFD1A85E0A67E86504B7E05482D8 vscode-uri-1.0.8.zip
+48304CC9611D4F3B4ACD5A6ABB88689913BFA7A0 https://doppel-helix.eu/test-typescript-update/48304CC9611D4F3B4ACD5A6ABB88689913BFA7A0-typescript-5.6.2.zip typescript-5.6.2.zip
+6895F0456E4B0FE3D857AA7D3F399932A026D060 https://doppel-helix.eu/test-typescript-update/typescript-language-server-4.3.3.zip typescript-language-server-4.3.3.zip
Review Comment:
Yes should have been done, I'm looking into this now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update Typescript Language Server to 4.4.3 [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing merged PR #7732:
URL: https://github.com/apache/netbeans/pull/7732
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update Typescript Language Server to 4.4.3 [netbeans]
Posted by "Chris2011 (via GitHub)" <gi...@apache.org>.
Chris2011 commented on PR #7732:
URL: https://github.com/apache/netbeans/pull/7732#issuecomment-2332632806
Another one for this piece of code
```typescript
const t = (obj) => {
}
t({
name: 2
})
```
When I remove character by character from the end of the file until beginning of name, I got this exception:
```
org.eclipse.lsp4j.jsonrpc.ResponseErrorException: <semantic> TypeScript Server Error (5.2.2)
Debug Failure. Expected 38 <= 37
Error: Debug Failure. Expected 38 <= 37
at assertDiagnosticLocation (c:\Projekte\Others\nuxt-asciidoc\node_modules\typescript\lib\tsserver.js:16251:11)
at createFileDiagnostic (c:\Projekte\Others\nuxt-asciidoc\node_modules\typescript\lib\tsserver.js:20244:3)
at getRangeToExtract2 (c:\Projekte\Others\nuxt-asciidoc\node_modules\typescript\lib\tsserver.js:141104:23)
at Object.getRefactorActionsToExtractSymbol [as getAvailableActions] (c:\Projekte\Others\nuxt-asciidoc\node_modules\typescript\lib\tsserver.js:140915:26)
at c:\Projekte\Others\nuxt-asciidoc\node_modules\typescript\lib\tsserver.js:137351:222
at flatMapIterator (c:\Projekte\Others\nuxt-asciidoc\node_modules\typescript\lib\tsserver.js:2630:19)
at flatMapIterator.next (<anonymous>)
at arrayFrom (c:\Projekte\Others\nuxt-asciidoc\node_modules\typescript\lib\tsserver.js:3184:14)
at Object.getApplicableRefactors (c:\Projekte\Others\nuxt-asciidoc\node_modules\typescript\lib\tsserver.js:137349:10)
at Object.getApplicableRefactors2 [as getApplicableRefactors] (c:\Projekte\Others\nuxt-asciidoc\node_modules\typescript\lib\tsserver.js:144816:32)
at IpcIOSession.getApplicableRefactors (c:\Projekte\Others\nuxt-asciidoc\node_modules\typescript\lib\tsserver.js:184449:41)
at getApplicableRefactors (c:\Projekte\Others\nuxt-asciidoc\node_modules\typescript\lib\tsserver.js:182686:43)
at c:\Projekte\Others\nuxt-asciidoc\node_modules\typescript\lib\tsserver.js:184838:69
at IpcIOSession.executeWithRequestId (c:\Projekte\Others\nuxt-asciidoc\node_modules\typescript\lib\tsserver.js:184830:14)
at IpcIOSession.executeCommand (c:\Projekte\Others\nuxt-asciidoc\node_modules\typescript\lib\tsserver.js:184838:29)
at IpcIOSession.onMessage (c:\Projekte\Others\nuxt-asciidoc\node_modules\typescript\lib\tsserver.js:184880:51)
at process.<anonymous> (c:\Projekte\Others\nuxt-asciidoc\node_modules\typescript\lib\tsserver.js:186461:14)
at process.emit (node:events:513:28)
at emit (node:internal/child_process:937:14)
at process.processTicksAndRejections (node:internal/process/task_queues:83:21)
at org.eclipse.lsp4j.jsonrpc.RemoteEndpoint.handleResponse(RemoteEndpoint.java:209)
at org.eclipse.lsp4j.jsonrpc.RemoteEndpoint.consume(RemoteEndpoint.java:193)
at org.eclipse.lsp4j.jsonrpc.json.StreamMessageProducer.handleMessage(StreamMessageProducer.java:194)
at org.eclipse.lsp4j.jsonrpc.json.StreamMessageProducer.listen(StreamMessageProducer.java:94)
at org.eclipse.lsp4j.jsonrpc.json.ConcurrentMessageProcessor.run(ConcurrentMessageProcessor.java:113)
at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at java.base/java.lang.Thread.run(Thread.java:842)
Caused: java.util.concurrent.ExecutionException
at java.base/java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:396)
at java.base/java.util.concurrent.CompletableFuture.get(CompletableFuture.java:2073)
[catch] at org.netbeans.modules.lsp.client.bindings.LanguageClientImpl$DiagnosticFixList.lambda$getFixes$1(LanguageClientImpl.java:340)
at org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:1403)
at org.netbeans.modules.openide.util.GlobalLookup.execute(GlobalLookup.java:45)
at org.openide.util.lookup.Lookups.executeWith(Lookups.java:287)
at org.openide.util.RequestProcessor$Processor.run(RequestProcessor.java:2018)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update Typescript Language Server to 4.4.3 [netbeans]
Posted by "lahodaj (via GitHub)" <gi...@apache.org>.
lahodaj commented on code in PR #7732:
URL: https://github.com/apache/netbeans/pull/7732#discussion_r1747689869
##########
webcommon/typescript.editor/external/typescript-5.5.4-license.txt:
##########
@@ -1,6 +1,6 @@
Name: typescript
Description: TypeScript is a language for application scale JavaScript development
-Version: 4.1.4
+Version: 5.5.4
Review Comment:
Sorry, but this seems highly suspicious to me. The `typescript-5.5.4.zip` file contains `typescript/ThirdPartyNoticeText.txt`, and I don't see the content of the file here. Is there a reason to believe the `typescript/ThirdPartyNoticeText.txt` does not apply here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update Typescript Language Server to 4.4.3 [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on code in PR #7732:
URL: https://github.com/apache/netbeans/pull/7732#discussion_r1920664078
##########
webcommon/typescript.editor/external/binaries-list:
##########
@@ -15,22 +15,5 @@
# specific language governing permissions and limitations
# under the License.
-EEBA3C1183C93B924F59F99D18143C6854855140 command-exists-1.2.6.zip
-D54E3334BE790F2AF65068B404E069AB7158795B commander-2.20.3.zip
-9545FC9061706C762E852F3D4DA3164EDFD96FE1 crypto-random-string-1.0.0.zip
-97705D5EE06EDD1981369ABD129EAC37C25DC5D5 fs-extra-7.0.1.zip
-DB515913528F8F8C48678FEF88697875ADEF133C graceful-fs-4.2.6.zip
-5A908B2D235A118C634F58E228B3992488847A98 jsonfile-4.0.0.zip
-F176424C20EE59996C503BAEBF18D2C70F184840 p-debounce-1.0.0.zip
-C553EC2693BF9B1E942E8DDFFBF6A591FE753F84 temp-dir-1.0.0.zip
-5C31F32D7D10CAB54F13408C64B42B62D51796EE tempy-0.2.1.zip
-B36AEE158BE444FD89CA51DBE61EC2BA4E7653AA typescript-4.1.4.zip
-719BC3E8A6F6DDA67A7E9642B498386D6CAD022A typescript-language-server-0.5.1.zip
-80FD5AA5DF32BE742BE353E5C4784868ED7D0D38 unique-string-1.0.0.zip
-BE24C4558E26E8B7CDEAFF2F9AE70D3BB5BEB0A8 universalify-0.1.2.zip
-09CF27455281E6C4FAA30571125D4F6E42EC3D5D vscode-jsonrpc-6.0.0.zip
-06B648FCE1A5B1FBC0306C30DB593AAAF6989A52 vscode-languageserver-5.3.0-next.10.zip
-6065994D322B86EB06D642F96F16018774E8440F vscode-languageserver-protocol-3.16.0.zip
-BC9B7B5E8243882E6AFC2D26D1008EF3F960F22F vscode-languageserver-types-3.16.0.zip
-191490D1923C11D2D7BFDB8F86CEB61567CA62A0 vscode-textbuffer-1.0.0.zip
-75BF5DA9B1BFDFD1A85E0A67E86504B7E05482D8 vscode-uri-1.0.8.zip
+48304CC9611D4F3B4ACD5A6ABB88689913BFA7A0 https://doppel-helix.eu/test-typescript-update/48304CC9611D4F3B4ACD5A6ABB88689913BFA7A0-typescript-5.6.2.zip typescript-5.6.2.zip
+6895F0456E4B0FE3D857AA7D3F399932A026D060 https://doppel-helix.eu/test-typescript-update/typescript-language-server-4.3.3.zip typescript-language-server-4.3.3.zip
Review Comment:
Update: https://github.com/apache/netbeans/pull/8168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update Typescript Language Server to 4.4.3 [netbeans]
Posted by "Chris2011 (via GitHub)" <gi...@apache.org>.
Chris2011 commented on PR #7732:
URL: https://github.com/apache/netbeans/pull/7732#issuecomment-2366946653
@matthiasblaesing I can confirm that I can't see any exception anymore. Thx :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update Typescript Language Server to 4.4.3 [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #7732:
URL: https://github.com/apache/netbeans/pull/7732#issuecomment-2330030523
@Chris2011 if I remember correctly, you are a user of the typescript support. Could you give the testbuild from this a spin?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update Typescript Language Server to 4.4.3 [netbeans]
Posted by "Chris2011 (via GitHub)" <gi...@apache.org>.
Chris2011 commented on PR #7732:
URL: https://github.com/apache/netbeans/pull/7732#issuecomment-2332604199
I created a new ts file and when I have this piece of code:
```const t: Record```
when call code completion after the end of the Record token and when I remove charaacter by character from the end of the Record token, I got this exception:
```
org.eclipse.lsp4j.jsonrpc.ResponseErrorException: Request completionItem/resolve failed with message: Cannot read properties of undefined (reading 'file')
at org.eclipse.lsp4j.jsonrpc.RemoteEndpoint.handleResponse(RemoteEndpoint.java:209)
at org.eclipse.lsp4j.jsonrpc.RemoteEndpoint.consume(RemoteEndpoint.java:193)
at org.eclipse.lsp4j.jsonrpc.json.StreamMessageProducer.handleMessage(StreamMessageProducer.java:194)
at org.eclipse.lsp4j.jsonrpc.json.StreamMessageProducer.listen(StreamMessageProducer.java:94)
at org.eclipse.lsp4j.jsonrpc.json.ConcurrentMessageProcessor.run(ConcurrentMessageProcessor.java:113)
at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at java.base/java.lang.Thread.run(Thread.java:842)
Caused: java.util.concurrent.ExecutionException
at java.base/java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:396)
at java.base/java.util.concurrent.CompletableFuture.get(CompletableFuture.java:2073)
[catch] at org.netbeans.modules.lsp.client.bindings.LspCompletionItem.resolveDocumentation(LspCompletionItem.java:104)
at org.netbeans.modules.lsp.client.bindings.AbstractCompletionItem$1.query(AbstractCompletionItem.java:154)
at org.netbeans.spi.editor.completion.support.AsyncCompletionTask.run(AsyncCompletionTask.java:198)
at org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:1403)
at org.netbeans.modules.openide.util.GlobalLookup.execute(GlobalLookup.java:45)
at org.openide.util.lookup.Lookups.executeWith(Lookups.java:287)
at org.openide.util.RequestProcessor$Processor.run(RequestProcessor.java:2018)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Update Typescript Language Server to 4.4.3 [netbeans]
Posted by "Chris2011 (via GitHub)" <gi...@apache.org>.
Chris2011 commented on PR #7732:
URL: https://github.com/apache/netbeans/pull/7732#issuecomment-2335161127
@matthiasblaesing for the first problem, you need to open the code completion first and delete char by char.
For the second error, in the first line you can see this: TypeScript Server Error (5.2.2) dunno whether this is the TS version or not. But I guess so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists