You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/03 13:35:24 UTC

[GitHub] [incubator-nuttx] donghengqaz edited a comment on pull request #2199: xtensa/esp32: SPI Flash driver uses global sem for all MTD

donghengqaz edited a comment on pull request #2199:
URL: https://github.com/apache/incubator-nuttx/pull/2199#issuecomment-720873284


   > @donghengqaz what was the issue? From the diff it looks that the only change is moving the mutex out of the struct.
   
   In my another MR: https://github.com/apache/incubator-nuttx/pull/2138, I will create some MTDs, if every MTD uses an independent semaphore, in some case like:
   
   `task_A reads MTD_1 and task_B writes MTD_2, and they run on different CPUs, the semaphore can't work as we expected.`
   
   https://github.com/espressif/esp-idf/blob/357a2776032299b8bc4044900a8f1d6950d7ce89/components/spi_flash/cache_utils.c#L84 also uses one global semaphore.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org