You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Blake Matheny (JIRA)" <ji...@apache.org> on 2011/08/15 18:47:27 UTC
[jira] [Created] (KAFKA-102) Shutting down Kafka should be FATAL,
not ERROR
Shutting down Kafka should be FATAL, not ERROR
----------------------------------------------
Key: KAFKA-102
URL: https://issues.apache.org/jira/browse/KAFKA-102
Project: Kafka
Issue Type: Bug
Components: core
Reporter: Blake Matheny
Priority: Minor
When Kafka encounters an unrecoverable error it generates an error level log record and then calls Runtime.getRuntime.halt(1). This should really be fatal, not an error.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-102) Shutting down Kafka should be FATAL,
not ERROR
Posted by "Blake Matheny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Blake Matheny updated KAFKA-102:
--------------------------------
Attachment: kafka-log.patch
> Shutting down Kafka should be FATAL, not ERROR
> ----------------------------------------------
>
> Key: KAFKA-102
> URL: https://issues.apache.org/jira/browse/KAFKA-102
> Project: Kafka
> Issue Type: Bug
> Components: core
> Reporter: Blake Matheny
> Priority: Minor
> Attachments: kafka-log.patch
>
>
> When Kafka encounters an unrecoverable error it generates an error level log record and then calls Runtime.getRuntime.halt(1). This should really be fatal, not an error.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-102) Shutting down Kafka should be FATAL,
not ERROR
Posted by "Jay Kreps (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085166#comment-13085166 ]
Jay Kreps commented on KAFKA-102:
---------------------------------
Thanks for catching this! While we are cleaning up we should fix the error messages. The capitalization is wrong and they reference internal method names, which makes them sysadmin unfriendly.
> Shutting down Kafka should be FATAL, not ERROR
> ----------------------------------------------
>
> Key: KAFKA-102
> URL: https://issues.apache.org/jira/browse/KAFKA-102
> Project: Kafka
> Issue Type: Bug
> Components: core
> Reporter: Blake Matheny
> Priority: Minor
> Attachments: kafka-log.patch
>
>
> When Kafka encounters an unrecoverable error it generates an error level log record and then calls Runtime.getRuntime.halt(1). This should really be fatal, not an error.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-102) Shutting down Kafka should be FATAL,
not ERROR
Posted by "Jay Kreps (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jay Kreps updated KAFKA-102:
----------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Applied.
> Shutting down Kafka should be FATAL, not ERROR
> ----------------------------------------------
>
> Key: KAFKA-102
> URL: https://issues.apache.org/jira/browse/KAFKA-102
> Project: Kafka
> Issue Type: Bug
> Components: core
> Reporter: Blake Matheny
> Priority: Minor
> Attachments: kafka-log-2.patch, kafka-log.patch
>
>
> When Kafka encounters an unrecoverable error it generates an error level log record and then calls Runtime.getRuntime.halt(1). This should really be fatal, not an error.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-102) Shutting down Kafka should be FATAL,
not ERROR
Posted by "Blake Matheny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Blake Matheny updated KAFKA-102:
--------------------------------
Status: Patch Available (was: Open)
> Shutting down Kafka should be FATAL, not ERROR
> ----------------------------------------------
>
> Key: KAFKA-102
> URL: https://issues.apache.org/jira/browse/KAFKA-102
> Project: Kafka
> Issue Type: Bug
> Components: core
> Reporter: Blake Matheny
> Priority: Minor
>
> When Kafka encounters an unrecoverable error it generates an error level log record and then calls Runtime.getRuntime.halt(1). This should really be fatal, not an error.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-102) Shutting down Kafka should be FATAL,
not ERROR
Posted by "Blake Matheny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Blake Matheny updated KAFKA-102:
--------------------------------
Attachment: kafka-log-2.patch
Updated the patch to at least cleanup the error/fatal logging in those two methods according to the kafka style guide.
> Shutting down Kafka should be FATAL, not ERROR
> ----------------------------------------------
>
> Key: KAFKA-102
> URL: https://issues.apache.org/jira/browse/KAFKA-102
> Project: Kafka
> Issue Type: Bug
> Components: core
> Reporter: Blake Matheny
> Priority: Minor
> Attachments: kafka-log-2.patch, kafka-log.patch
>
>
> When Kafka encounters an unrecoverable error it generates an error level log record and then calls Runtime.getRuntime.halt(1). This should really be fatal, not an error.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-102) Shutting down Kafka should be FATAL,
not ERROR
Posted by "Jay Kreps (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085179#comment-13085179 ]
Jay Kreps commented on KAFKA-102:
---------------------------------
+1
> Shutting down Kafka should be FATAL, not ERROR
> ----------------------------------------------
>
> Key: KAFKA-102
> URL: https://issues.apache.org/jira/browse/KAFKA-102
> Project: Kafka
> Issue Type: Bug
> Components: core
> Reporter: Blake Matheny
> Priority: Minor
> Attachments: kafka-log-2.patch, kafka-log.patch
>
>
> When Kafka encounters an unrecoverable error it generates an error level log record and then calls Runtime.getRuntime.halt(1). This should really be fatal, not an error.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira