[GitHub] [ignite-3] zstan commented on a diff in pull request #1418: IGNITE-18282: Illegal use of dynamic parameter exception in SQL functions

[GitBox <gi...@apache.org>]

zstan commented on code in PR #1418:
URL: https://github.com/apache/ignite-3/pull/1418#discussion_r1042315835


##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/type/IgniteTypeFactory.java:
##########
@@ -353,6 +353,21 @@ public Charset getDefaultCharset() {
         return super.toSql(type);
     }
 
+
+    /** Returns custom type.  {@code Null} if custom type not found */
+    public RelDataType createCustomType(Type type) {
+        return createCustomType(type, true);
+    }
+
+    /** Returns nullable custom type. {@code Null} if custom type not found. */
+    public RelDataType createCustomType(Type type, boolean nullable) {

Review Comment:
   plz append @Nullable



##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/type/IgniteCustomType.java:
##########
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.sql.engine.type;
+
+import org.apache.calcite.rel.type.RelDataTypeFamily;
+import org.apache.calcite.rel.type.RelDataTypeImpl;
+import org.apache.calcite.sql.type.SqlTypeFamily;
+import org.apache.calcite.sql.type.SqlTypeName;
+
+/** Custom type base. */
+public abstract class IgniteCustomType extends RelDataTypeImpl {
+    /** Nullable flag. */
+    private final boolean nullable;
+
+    /** Ctor. */
+    protected IgniteCustomType(boolean nullable) {
+        this.nullable = nullable;
+
+        computeDigest();
+    }
+
+    /** {@inheritDoc} */
+    @Override
+    public boolean isNullable() {
+        return nullable;
+    }
+
+    /** {@inheritDoc} */
+    @Override
+    public RelDataTypeFamily getFamily() {
+        return SqlTypeFamily.ANY;

Review Comment:
   ```suggestion
           return SqlTypeName.ANY.getFamily();
   ```



##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/type/OtherType.java:
##########
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.sql.engine.type;
+
+/** OTHER SQL type for any value. */

Review Comment:
   non informative java doc a la ai-2 style also implementation details are mentioned ...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org