[jira] [Commented] (ASTERIXDB-2619) Add extra test cases for bitwise functions

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ASTERIXDB-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16899360#comment-16899360 ] 

ASF subversion and git services commented on ASTERIXDB-2619:
------------------------------------------------------------

Commit 72bca2a63799442c23f183f6acc95caeccb7e2a4 in asterixdb's branch refs/heads/master from Hussain Towaileb
[ https://gitbox.apache.org/repos/asf?p=asterixdb.git;h=72bca2a ]

[ASTERIXDB-2619][FUN] Add extra test cases for bitwise functions

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Added test cases based on reading data from dataset to ensure
  the function performs properly on subsequent calls, and ensure
  it works properly if it doesn't go through the constant folding
  rule.
- Fixed an issue in the bitcount function which was resulting in
  Serialization Exception when calling the function with fields
  rather than constants.
- Fixed an issue with bittest and isbitset which was resulting in
  wrong value in some cases due to not reseting the monitoring of
  allSet check flag.

Change-Id: Ie1d8e4f8594843f98e7a1cf8a2da4b0106597ae8
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3514
Contrib: Jenkins <je...@fulliautomatix.ics.uci.edu>
Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: Hussain Towaileb <hu...@gmail.com>
Reviewed-by: Dmitry Lychagin <dm...@couchbase.com>


> Add extra test cases for bitwise functions
> ------------------------------------------
>
>                 Key: ASTERIXDB-2619
>                 URL: https://issues.apache.org/jira/browse/ASTERIXDB-2619
>             Project: Apache AsterixDB
>          Issue Type: Task
>          Components: FUN - Functions
>    Affects Versions: 0.9.4
>            Reporter: Hussain Towaileb
>            Assignee: Hussain Towaileb
>            Priority: Major
>             Fix For: 0.9.5
>
>
> Need to add extra test cases that read the data from a dataset/variables to ensure proper behavior with subsequent calls and not going through the constant folding rule when performing the operations.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)