You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by andralungu <gi...@git.apache.org> on 2015/06/02 21:04:38 UTC
[GitHub] flink pull request: [docs/javadoc][hotfix] Corrected Join hint and...
GitHub user andralungu opened a pull request:
https://github.com/apache/flink/pull/763
[docs/javadoc][hotfix] Corrected Join hint and misleadling pointer to Spargel
This PR adds the following patches:
- in the Iteration programming guide, there was a misleading link to Spargel, which is deprecated; I switched it to point to Gelly;
- while trying to use join hints, I saw that the JavaDoc for BROADCAST_HASH_SECOND was wrong; "Hint that the *second* join input is much smaller than the *second*". Fixed it to be smaller than the first :)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andralungu/flink documPatch
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/763.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #763
----
commit 955ed6e3106d32b22933f0ce637bf38fa2faef72
Author: andralungu <lu...@gmail.com>
Date: 2015-06-02T18:58:10Z
[docs/javadoc][hotfix] Corrected Join hint and misleadling pointer to Spargel
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [docs/javadoc][hotfix] Corrected Join hint and...
Posted by vasia <gi...@git.apache.org>.
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/763#issuecomment-108262606
looks good, +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [docs/javadoc][hotfix] Corrected Join hint and...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/763#issuecomment-108810129
Merging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [docs/javadoc][hotfix] Corrected Join hint and...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/763
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [docs/javadoc][hotfix] Corrected Join hint and...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/763#issuecomment-108795853
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---