[jira] [Commented] (AIRFLOW-2339) setup.py version doesn't use git info

["Siddharth Anand (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16443385#comment-16443385 ] 

Siddharth Anand commented on AIRFLOW-2339:
------------------------------------------

Feel free to implement a solution for us to review.

> setup.py version doesn't use git info
> -------------------------------------
>
>                 Key: AIRFLOW-2339
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-2339
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: configuration
>    Affects Versions: 1.9.0
>            Reporter: John Arnold
>            Assignee: John Arnold
>            Priority: Major
>
> In setup.py, the function git_version() is used to determine if the package is being built from git, and if a release tag or commit hash should inform the version information.
> This info is written to a file, but it's never used when building a package. The package version is always 1.x.x.dev0+incubating when building a dev / non-release package.
> This is not really PEP440 compliant, and is a sucky experience when trying to generate packages in between major releases (for bugfixes, primarily).
> I can manually manipulate the version info in version.py to force unique build numbers, but this makes for a lot of extra work.  It would be nice to wire in either pbr or versioneer, or mayb ejust miniver/miniver2 to do the work for us, and generate nice PEP440 versions, e.g.:
> 1.20.0.dev0+N.MMMMM    where N is the number of commits since the last release, and MMMMM is the commit hash.   The incrementing of N makes for nice version upgrades with pip.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)