You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2018/01/18 00:13:05 UTC
[kudu-CR] rpc: avoid an extra copy of shared ptr for OutboundCall
Hello Michael Ho, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/9047
to review the following change.
Change subject: rpc: avoid an extra copy of shared_ptr for OutboundCall
......................................................................
rpc: avoid an extra copy of shared_ptr for OutboundCall
Change-Id: I89356bd9c59e612e64ffc4e1ad4a6bfda44512aa
---
M src/kudu/rpc/connection.cc
M src/kudu/rpc/connection.h
M src/kudu/rpc/reactor.cc
M src/kudu/rpc/reactor.h
4 files changed, 7 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/9047/1
--
To view, visit http://gerrit.cloudera.org:8080/9047
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I89356bd9c59e612e64ffc4e1ad4a6bfda44512aa
Gerrit-Change-Number: 9047
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
[kudu-CR] rpc: avoid an extra copy of shared ptr for OutboundCall
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9047 )
Change subject: rpc: avoid an extra copy of shared_ptr for OutboundCall
......................................................................
rpc: avoid an extra copy of shared_ptr for OutboundCall
Change-Id: I89356bd9c59e612e64ffc4e1ad4a6bfda44512aa
Reviewed-on: http://gerrit.cloudera.org:8080/9047
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-by: Michael Ho <kw...@cloudera.com>
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/rpc/connection.cc
M src/kudu/rpc/connection.h
M src/kudu/rpc/reactor.cc
M src/kudu/rpc/reactor.h
4 files changed, 7 insertions(+), 7 deletions(-)
Approvals:
Adar Dembo: Looks good to me, but someone else must approve
Kudu Jenkins: Verified
Michael Ho: Looks good to me, but someone else must approve
Todd Lipcon: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/9047
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I89356bd9c59e612e64ffc4e1ad4a6bfda44512aa
Gerrit-Change-Number: 9047
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] rpc: avoid an extra copy of shared ptr for OutboundCall
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9047 )
Change subject: rpc: avoid an extra copy of shared_ptr for OutboundCall
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9047
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89356bd9c59e612e64ffc4e1ad4a6bfda44512aa
Gerrit-Change-Number: 9047
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 18 Jan 2018 01:26:14 +0000
Gerrit-HasComments: No
[kudu-CR] rpc: avoid an extra copy of shared ptr for OutboundCall
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9047 )
Change subject: rpc: avoid an extra copy of shared_ptr for OutboundCall
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/9047
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89356bd9c59e612e64ffc4e1ad4a6bfda44512aa
Gerrit-Change-Number: 9047
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Jan 2018 01:25:09 +0000
Gerrit-HasComments: No
[kudu-CR] rpc: avoid an extra copy of shared ptr for OutboundCall
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9047 )
Change subject: rpc: avoid an extra copy of shared_ptr for OutboundCall
......................................................................
Patch Set 1: Code-Review+1
Looks good to me, but I think Michael is more familiar with this code.
--
To view, visit http://gerrit.cloudera.org:8080/9047
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89356bd9c59e612e64ffc4e1ad4a6bfda44512aa
Gerrit-Change-Number: 9047
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Jan 2018 00:30:48 +0000
Gerrit-HasComments: No