You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Dmitry Malenok (JIRA)" <ji...@codehaus.org> on 2011/05/18 08:02:22 UTC

[jira] Created: (SUREFIRE-740) Fractional part of method execution time is truncated for non English locale

Fractional part of method execution time is truncated for non English locale
----------------------------------------------------------------------------

                 Key: SUREFIRE-740
                 URL: http://jira.codehaus.org/browse/SUREFIRE-740
             Project: Maven Surefire
          Issue Type: Bug
          Components: Maven Surefire Report Plugin
    Affects Versions: 2.8.1
         Environment: Windows 7 Pro x64 with Russian locale/JDK 1.6.0_21/Apache Maven 3.0.3 (r1075438; 2011-02-28 20:31:09+0300)
            Reporter: Dmitry Malenok


The problem is that Maven Surefire Plugin and Maven Surefire Report Plugin use different locales for writing and reading TEST-* file if the default locale is not set to English locale.The first one always uses "Locale.ENGLISH" (org.apache.maven.surefire.report.AbstractReporter, line 43), but the second one uses the default locale (org.apache.maven.plugins.surefire.report.TestSuiteXmlParser, line 50). Russian and English locale use different decimal symbol ("," - Russian locale, '.' - English locale) that causes the described problem.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (SUREFIRE-740) Fractional part of method execution time is truncated for non English locale

Posted by "Kristian Rosenvold (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/SUREFIRE-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=267356#action_267356 ] 

Kristian Rosenvold commented on SUREFIRE-740:
---------------------------------------------

Never mind, found them myself. MAVEN_OPTS="-Duser.language=ru -Duser.country=RU". German exhibits problem too

> Fractional part of method execution time is truncated for non English locale
> ----------------------------------------------------------------------------
>
>                 Key: SUREFIRE-740
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-740
>             Project: Maven Surefire
>          Issue Type: Bug
>          Components: Maven Surefire Report Plugin
>    Affects Versions: 2.8.1
>         Environment: Windows 7 Pro x64 with Russian locale/JDK 1.6.0_21/Apache Maven 3.0.3 (r1075438; 2011-02-28 20:31:09+0300)
>            Reporter: Dmitry Malenok
>
> The problem is that Maven Surefire Plugin and Maven Surefire Report Plugin use different locales for writing and reading TEST-* file if the default locale is not set to English locale.The first one always uses "Locale.ENGLISH" (org.apache.maven.surefire.report.AbstractReporter, line 43), but the second one uses the default locale (org.apache.maven.plugins.surefire.report.TestSuiteXmlParser, line 50). Russian and English locale use different decimal symbol ("," - Russian locale, '.' - English locale) that causes the described problem.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (SUREFIRE-740) Fractional part of method execution time is truncated for non English locale

Posted by "Kristian Rosenvold (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/SUREFIRE-740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Rosenvold closed SUREFIRE-740.
---------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.8.2
         Assignee: Kristian Rosenvold

Thanks for a good bug report !
 
Fixed with integration test in r1125058. I believe this affects most non-english european locales.

> Fractional part of method execution time is truncated for non English locale
> ----------------------------------------------------------------------------
>
>                 Key: SUREFIRE-740
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-740
>             Project: Maven Surefire
>          Issue Type: Bug
>          Components: Maven Surefire Report Plugin
>    Affects Versions: 2.8.1
>         Environment: Windows 7 Pro x64 with Russian locale/JDK 1.6.0_21/Apache Maven 3.0.3 (r1075438; 2011-02-28 20:31:09+0300)
>            Reporter: Dmitry Malenok
>            Assignee: Kristian Rosenvold
>             Fix For: 2.9
>
>
> The problem is that Maven Surefire Plugin and Maven Surefire Report Plugin use different locales for writing and reading TEST-* file if the default locale is not set to English locale.The first one always uses "Locale.ENGLISH" (org.apache.maven.surefire.report.AbstractReporter, line 43), but the second one uses the default locale (org.apache.maven.plugins.surefire.report.TestSuiteXmlParser, line 50). Russian and English locale use different decimal symbol ("," - Russian locale, '.' - English locale) that causes the described problem.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (SUREFIRE-740) Fractional part of method execution time is truncated for non English locale

Posted by "Kristian Rosenvold (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/SUREFIRE-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=267354#action_267354 ] 

Kristian Rosenvold commented on SUREFIRE-740:
---------------------------------------------

Do you have the appropriate value for  -Duser.language= -Duser.country= and -Duser.variant= to reproduce this ? I really need it for an integration test (As usual, the fix in the code is 1 line and 5 minutes, creating a test is much harder...)

> Fractional part of method execution time is truncated for non English locale
> ----------------------------------------------------------------------------
>
>                 Key: SUREFIRE-740
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-740
>             Project: Maven Surefire
>          Issue Type: Bug
>          Components: Maven Surefire Report Plugin
>    Affects Versions: 2.8.1
>         Environment: Windows 7 Pro x64 with Russian locale/JDK 1.6.0_21/Apache Maven 3.0.3 (r1075438; 2011-02-28 20:31:09+0300)
>            Reporter: Dmitry Malenok
>
> The problem is that Maven Surefire Plugin and Maven Surefire Report Plugin use different locales for writing and reading TEST-* file if the default locale is not set to English locale.The first one always uses "Locale.ENGLISH" (org.apache.maven.surefire.report.AbstractReporter, line 43), but the second one uses the default locale (org.apache.maven.plugins.surefire.report.TestSuiteXmlParser, line 50). Russian and English locale use different decimal symbol ("," - Russian locale, '.' - English locale) that causes the described problem.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira