You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "vatsrahul1001 (via GitHub)" <gi...@apache.org> on 2023/08/14 17:00:02 UTC
[GitHub] [airflow] vatsrahul1001 opened a new issue, #33392: Setting SHOW_TRIGGER_FORM_IF_NO_PARAMS=True redirecting to trigger form for every DAG instead of giving an option to select as in 2.6.3
vatsrahul1001 opened a new issue, #33392:
URL: https://github.com/apache/airflow/issues/33392
### Apache Airflow version
airflow main branch
### What happened
While Testing [PR](https://github.com/apache/airflow/pull/33351), i noticed after setting `AIRFLOW__WEBSERVER__SHOW_TRIGGER_FORM_IF_NO_PARAMS =True`, even the DAG which does not have Params or dag_run.conf is getting redirecting automatically to trigger w/ config form
### What you think should happen instead
As per me this should give the option to trigger with conf or not instead to redirecting automatically as we should to have in 2.6.3In
### How to reproduce
Run breeze with latest main set `AIRFLOW__WEBSERVER__SHOW_TRIGGER_FORM_IF_NO_PARAMS=True` and try to trigger any DAG its automatically redirecting to trigger config form
### Operating System
Mac os
### Versions of Apache Airflow Providers
_No response_
### Deployment
Astronomer
### Deployment details
_No response_
### Anything else
_No response_
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #33392: Setting SHOW_TRIGGER_FORM_IF_NO_PARAMS=True redirecting to trigger form for every DAG instead of giving an option to select as in 2.6.3
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #33392:
URL: https://github.com/apache/airflow/issues/33392#issuecomment-1677698286
Thanks for the report. This has already been addressed and the main reason why we cancelled RC1 voting and we are going to have RC2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] vatsrahul1001 commented on issue #33392: Setting SHOW_TRIGGER_FORM_IF_NO_PARAMS=True redirecting to trigger form for every DAG instead of giving an option to select as in 2.6.3
Posted by "vatsrahul1001 (via GitHub)" <gi...@apache.org>.
vatsrahul1001 commented on issue #33392:
URL: https://github.com/apache/airflow/issues/33392#issuecomment-1677708840
@potiukthis bug is against the [PR](https://github.com/apache/airflow/pull/33351) was which was fix against the [bug](https://github.com/apache/airflow/issues/33344) i raised earlier,setting SHOW_TRIGGER_FORM_IF_NO_PARAMS=True should go back to original behavior as mentioned [here](https://github.com/apache/airflow/pull/33351#issuecomment-1676121764), however, its automatically redirecting to trigger page for every DAG which is not right
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy closed issue #33392: Setting SHOW_TRIGGER_FORM_IF_NO_PARAMS=True redirecting to trigger form for every DAG instead of giving an option to select as in 2.6.3
Posted by "ephraimbuddy (via GitHub)" <gi...@apache.org>.
ephraimbuddy closed issue #33392: Setting SHOW_TRIGGER_FORM_IF_NO_PARAMS=True redirecting to trigger form for every DAG instead of giving an option to select as in 2.6.3
URL: https://github.com/apache/airflow/issues/33392
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on issue #33392: Setting SHOW_TRIGGER_FORM_IF_NO_PARAMS=True redirecting to trigger form for every DAG instead of giving an option to select as in 2.6.3
Posted by "ephraimbuddy (via GitHub)" <gi...@apache.org>.
ephraimbuddy commented on issue #33392:
URL: https://github.com/apache/airflow/issues/33392#issuecomment-1678439160
Resolved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jens-scheffler-bosch commented on issue #33392: Setting SHOW_TRIGGER_FORM_IF_NO_PARAMS=True redirecting to trigger form for every DAG instead of giving an option to select as in 2.6.3
Posted by "jens-scheffler-bosch (via GitHub)" <gi...@apache.org>.
jens-scheffler-bosch commented on issue #33392:
URL: https://github.com/apache/airflow/issues/33392#issuecomment-1677773825
The statement I tried to make in the "hof fix PR" was meant to get to get "functional" on the same level not exactly re-producing the exact visual. Main point was that it was not able to trigger a DAG with config when no params are defined - and ths the form automatically be skipped.
It was not expressed that it is "critical" to replicate the same popup, thus being able to skip w/o config also if params are defined.
I originally proposed multiple options from which the voted option was implemented. The hotfix was intended to re-establish the option for users to force a config. Reverting all the visual is more than a small change, I'd propose to re-discuss the final "target" behavior, seems to be multiple opinions around what a trigger button should do and what not. One or the other way, two click are needed to trigger.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed issue #33392: Setting SHOW_TRIGGER_FORM_IF_NO_PARAMS=True redirecting to trigger form for every DAG instead of giving an option to select as in 2.6.3
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed issue #33392: Setting SHOW_TRIGGER_FORM_IF_NO_PARAMS=True redirecting to trigger form for every DAG instead of giving an option to select as in 2.6.3
URL: https://github.com/apache/airflow/issues/33392
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on issue #33392: Setting SHOW_TRIGGER_FORM_IF_NO_PARAMS=True redirecting to trigger form for every DAG instead of giving an option to select as in 2.6.3
Posted by "ephraimbuddy (via GitHub)" <gi...@apache.org>.
ephraimbuddy commented on issue #33392:
URL: https://github.com/apache/airflow/issues/33392#issuecomment-1677710963
> Thanks for the report. This has already been addressed and the main reason why we cancelled RC1 voting and we are going to have RC2.
@potiuk , this seems different. When the config is enabled, every dag when triggered opens up the trigger page but previously, you have the option of choosing to trigger with config or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #33392: Setting SHOW_TRIGGER_FORM_IF_NO_PARAMS=True redirecting to trigger form for every DAG instead of giving an option to select as in 2.6.3
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #33392:
URL: https://github.com/apache/airflow/issues/33392#issuecomment-1677711970
Ah. OK Sorry then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org