You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@madlib.apache.org by fm...@apache.org on 2019/10/28 17:11:10 UTC

[madlib] 02/02: Address review comments

This is an automated email from the ASF dual-hosted git repository.

fmcquillan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/madlib.git

commit 72dfd30df1b7e79525de825c56e81b423e0c3d1b
Author: Orhan Kislal <ok...@apache.org>
AuthorDate: Fri Oct 25 11:35:51 2019 -0400

    Address review comments
---
 RELEASE_NOTES                                                | 2 +-
 src/ports/postgres/modules/deep_learning/madlib_keras.sql_in | 5 +++--
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/RELEASE_NOTES b/RELEASE_NOTES
index d4296ec..5b8e0ae 100644
--- a/RELEASE_NOTES
+++ b/RELEASE_NOTES
@@ -15,7 +15,7 @@ MADlib v1.17:
 Release Date:
 
 Other:
-    - DL: Supported keras version is fixed to 2.2.4
+    - DL: Supported keras version is capped at 2.2.4, tensorflow version is capped at 1.14.
 
 —-------------------------------------------------------------------------
 MADlib v1.16:
diff --git a/src/ports/postgres/modules/deep_learning/madlib_keras.sql_in b/src/ports/postgres/modules/deep_learning/madlib_keras.sql_in
index 9c4f39a..4ffec57 100644
--- a/src/ports/postgres/modules/deep_learning/madlib_keras.sql_in
+++ b/src/ports/postgres/modules/deep_learning/madlib_keras.sql_in
@@ -77,8 +77,9 @@ typically resulting faster and smoother convergence [3].
 You can also do inference on models that have not been trained with MADlib,
 but rather imported from an external source.
 
-Note that the following MADlib functions are targetting a specific Keras
-version (2.2.4). Using a newer or older version may or may not work as intended.
+Note that the following MADlib functions are targeting a specific Keras
+version (2.2.4) with a specific Tensorflow kernel version (1.14).
+Using a newer or older version may or may not work as intended.
 
 @brief Solves image classification problems by calling
 the Keras API