You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2017/11/22 14:00:01 UTC
Review Request 64030: Modify AMBARI-22387 to Check for LZO + No Opt-in
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64030/
-----------------------------------------------------------
Review request for Ambari, Jonathan Hurley and Nate Cole.
Bugs: AMBARI-22500
https://issues.apache.org/jira/browse/AMBARI-22500
Repository: ambari
Description
-------
The work for AMBARI-22387 was initially created to warn the user before performing an upgrade that LZO was enabled and would need to be managed on their own. However, with AMBARI-22457, we now support LZO when a user opts-in to installed GPL-licensed code.
The warning in AMBARI-22387 should be changed to check for LZO being enabled but the user _NOT_ opt-ing in
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/checks/LZOCheck.java 9c0286b
ambari-server/src/test/java/org/apache/ambari/server/checks/LZOCheckTest.java e50e936
Diff: https://reviews.apache.org/r/64030/diff/1/
Testing
-------
mvn clean test
and check on live cluster
Thanks,
Dmitro Lisnichenko
Re: Review Request 64030: Modify AMBARI-22387 to Check for LZO + No
Opt-in
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64030/#review191734
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Nov. 22, 2017, 9 a.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64030/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2017, 9 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-22500
> https://issues.apache.org/jira/browse/AMBARI-22500
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The work for AMBARI-22387 was initially created to warn the user before performing an upgrade that LZO was enabled and would need to be managed on their own. However, with AMBARI-22457, we now support LZO when a user opts-in to installed GPL-licensed code.
>
> The warning in AMBARI-22387 should be changed to check for LZO being enabled but the user _NOT_ opt-ing in
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/LZOCheck.java 9c0286b
> ambari-server/src/test/java/org/apache/ambari/server/checks/LZOCheckTest.java e50e936
>
>
> Diff: https://reviews.apache.org/r/64030/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
> and check on live cluster
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 64030: Modify AMBARI-22387 to Check for LZO + No
Opt-in
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64030/#review191741
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Nov. 22, 2017, 9 a.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64030/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2017, 9 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-22500
> https://issues.apache.org/jira/browse/AMBARI-22500
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The work for AMBARI-22387 was initially created to warn the user before performing an upgrade that LZO was enabled and would need to be managed on their own. However, with AMBARI-22457, we now support LZO when a user opts-in to installed GPL-licensed code.
>
> The warning in AMBARI-22387 should be changed to check for LZO being enabled but the user _NOT_ opt-ing in
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/LZOCheck.java 9c0286b
> ambari-server/src/test/java/org/apache/ambari/server/checks/LZOCheckTest.java e50e936
>
>
> Diff: https://reviews.apache.org/r/64030/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
> and check on live cluster
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 64030: Modify AMBARI-22387 to Check for LZO + No
Opt-in
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64030/
-----------------------------------------------------------
(Updated Nov. 22, 2017, 5:43 p.m.)
Review request for Ambari, Jonathan Hurley and Nate Cole.
Changes
-------
Fix order of imports
Bugs: AMBARI-22500
https://issues.apache.org/jira/browse/AMBARI-22500
Repository: ambari
Description
-------
The work for AMBARI-22387 was initially created to warn the user before performing an upgrade that LZO was enabled and would need to be managed on their own. However, with AMBARI-22457, we now support LZO when a user opts-in to installed GPL-licensed code.
The warning in AMBARI-22387 should be changed to check for LZO being enabled but the user _NOT_ opt-ing in
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/checks/LZOCheck.java 9c0286b
ambari-server/src/test/java/org/apache/ambari/server/checks/LZOCheckTest.java e50e936
Diff: https://reviews.apache.org/r/64030/diff/2/
Changes: https://reviews.apache.org/r/64030/diff/1-2/
Testing
-------
mvn clean test
and check on live cluster
Thanks,
Dmitro Lisnichenko