You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/08/18 18:24:02 UTC
[GitHub] [cordova-plugin-inappbrowser] mrbberra opened a new pull request #765: (ios) Add InAppBrowserStatusBarStyle preference #728
mrbberra opened a new pull request #765:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/765
### Platforms affected
iOS
### Motivation and Context
This allows apps that set a dark status bar background color using [cordova-plugin-statusbar](https://github.com/apache/cordova-plugin-statusbar) to set the status bar style when using the in app browser. Became necessary after [GH-656](https://github.com/apache/cordova-plugin-inappbrowser/pull/656).
Fixes: #728
### Description
Adds the ability to set `<preference name="InAppBrowserStatusBarStyle" value="lightcontent" />` in the config.xml file, so that the `preferredStatusBarStyle` becomes `UIStatusBarStyleLightContent` instead of `UIStatusBarStyleDefault`.
### Testing
I created a [test app](https://github.com/mrbberra/inappbrowser-statusbar-style) and tried setting the InAppBrowserStatusBarStyle to "default", "lightcontent", and removing it alltogether. I didn't add any new automatic tests- not sure how.
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [x] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] mosabab commented on pull request #765: (ios) Add InAppBrowserStatusBarStyle preference
Posted by GitBox <gi...@apache.org>.
mosabab commented on pull request #765:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/765#issuecomment-684992602
> I've tested this with my [test harness project](https://github.com/dpa99c/cordova-plugin-inappbrowser-test) and confirm it works as intended.
Thanks for test and merges.
Does anyone add this <preference name="InAppBrowserStatusBarStyle" value="lightcontent" /> to config.xml documents ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] dpa99c merged pull request #765: (ios) Add InAppBrowserStatusBarStyle preference
Posted by GitBox <gi...@apache.org>.
dpa99c merged pull request #765:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/765
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] mosabab edited a comment on pull request #765: (ios) Add InAppBrowserStatusBarStyle preference
Posted by GitBox <gi...@apache.org>.
mosabab edited a comment on pull request #765:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/765#issuecomment-684992602
> I've tested this with my [test harness project](https://github.com/dpa99c/cordova-plugin-inappbrowser-test) and confirm it works as intended.
Thanks for test and merges.
Does anyone add this `<preference name="InAppBrowserStatusBarStyle" value="lightcontent" />` to config.xml (https://github.com/apache/cordova-docs/blob/master/www/docs/en/dev/config_ref/index.md) documents ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] dpa99c commented on pull request #765: (ios) Add InAppBrowserStatusBarStyle preference
Posted by GitBox <gi...@apache.org>.
dpa99c commented on pull request #765:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/765#issuecomment-684947374
I've tested this with my [test harness project](https://github.com/dpa99c/cordova-plugin-inappbrowser-test) and confirm it works as intended.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] mosabab edited a comment on pull request #765: (ios) Add InAppBrowserStatusBarStyle preference
Posted by GitBox <gi...@apache.org>.
mosabab edited a comment on pull request #765:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/765#issuecomment-684992602
> I've tested this with my [test harness project](https://github.com/dpa99c/cordova-plugin-inappbrowser-test) and confirm it works as intended.
Thanks for test and merges.
Does anyone add this `<preference name="InAppBrowserStatusBarStyle" value="lightcontent" />` to config.xml documents ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] mosabab edited a comment on pull request #765: (ios) Add InAppBrowserStatusBarStyle preference
Posted by GitBox <gi...@apache.org>.
mosabab edited a comment on pull request #765:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/765#issuecomment-684992602
> I've tested this with my [test harness project](https://github.com/dpa99c/cordova-plugin-inappbrowser-test) and confirm it works as intended.
Thanks for test and merges.
Does anyone add this `<preference name="InAppBrowserStatusBarStyle" value="lightcontent" />` to config.xml (https://github.com/apache/cordova-docs/blob/master/www/docs/en/dev/config_ref/index.md) documents ?
If not, i will add a pull request to explain this in general Config.xml Docs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org