[jira] [Commented] (PHOENIX-5839) CompatUtil#setStopRow semantics problem

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-5839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206214#comment-17206214 ] 

ASF GitHub Bot commented on PHOENIX-5839:
-----------------------------------------

richardantal commented on pull request #763:
URL: https://github.com/apache/phoenix/pull/763#issuecomment-702759276


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> CompatUtil#setStopRow semantics problem
> ---------------------------------------
>
>                 Key: PHOENIX-5839
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5839
>             Project: Phoenix
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 4.x
>            Reporter: Istvan Toth
>            Assignee: Istvan Toth
>            Priority: Major
>         Attachments: PHOENIX-5839.4.x.v1.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> As noticed by [~gjacoby] , the semantics of the CompatUtil#setStopRow method are incorrect for HBase 1.3. Specifically, we invert the semantics of the *inclusive* flag.
> Due to the quirks of the HBase 1.3 scan semantics, the resulting behaviour in the specific cases where it used is correct (in fact this behaviour is needed for correct operation), but when used outside this specific use case (single row scan), it would cause problems.
> Find some other solution that solves the backwards compatibility problem, and does not invert the semantics of the call in the range (not single row) scan case.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)