You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "umlublin (via GitHub)" <gi...@apache.org> on 2024/09/06 14:58:50 UTC
[PR] Fix NTLMv2 auth problems for AD 2012 and above [httpcomponents-client]
umlublin opened a new pull request, #578:
URL: https://github.com/apache/httpcomponents-client/pull/578
Without this flag actual code will be using NTLMv2Session response instead of NTLMv2 response.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: [PR] Fix NTLMv2 auth problems for AD 2012 and above [httpcomponents-client]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #578:
URL: https://github.com/apache/httpcomponents-client/pull/578#issuecomment-2337635254
Just read the spec, the flag is fine, but consider that NTLM is dead in general.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: [PR] Fix NTLMv2 auth problems for AD 2012 and above [httpcomponents-client]
Posted by "ok2c (via GitHub)" <gi...@apache.org>.
ok2c commented on PR #578:
URL: https://github.com/apache/httpcomponents-client/pull/578#issuecomment-2334285946
@umlublin We, as a project, no longer support NTLM. I can merge your change as is, not having a slightest idea what it does, but I cannot promise it will ever make into a release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: [PR] Fix NTLMv2 auth problems for AD 2012 and above [httpcomponents-client]
Posted by "ok2c (via GitHub)" <gi...@apache.org>.
ok2c commented on PR #578:
URL: https://github.com/apache/httpcomponents-client/pull/578#issuecomment-2353345795
@umlublin I just realized that your change-set had broken one of the test cases. I am going to revert it. Feel free to re-introduce it if you also fix the failing test case
```
ERROR] Failures:
[ERROR] TestNTLMEngineImpl.testType1Message:243->checkArraysMatch:323 expected:<1> but was:<5>
[INFO]
[ERROR] Tests run: 938, Failures: 1, Errors: 0, Skipped: 0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: [PR] Fix NTLMv2 auth problems for AD 2012 and above [httpcomponents-client]
Posted by "umlublin (via GitHub)" <gi...@apache.org>.
umlublin commented on PR #578:
URL: https://github.com/apache/httpcomponents-client/pull/578#issuecomment-2334359169
NTLM is deprecated in 5.x
4.5.x with bad NTLM support is still used by Sonatype Nexus or Jenkins
https://hc.apache.org/httpcomponents-client-4.5.x/ntlm.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: [PR] Fix NTLMv2 auth problems for AD 2012 and above [httpcomponents-client]
Posted by "ok2c (via GitHub)" <gi...@apache.org>.
ok2c commented on PR #578:
URL: https://github.com/apache/httpcomponents-client/pull/578#issuecomment-2334502048
@umlublin Feel free to port your fix to master (5.4) and advise those projects to migrate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: [PR] Fix NTLMv2 auth problems for AD 2012 and above [httpcomponents-client]
Posted by "ok2c (via GitHub)" <gi...@apache.org>.
ok2c merged PR #578:
URL: https://github.com/apache/httpcomponents-client/pull/578
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org