You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/10/28 01:00:22 UTC
[GitHub] [shardingsphere-elasticjob] TeslaCN opened a new pull request #1668: Specify highest version of Spring Framework in dependencyManagement
TeslaCN opened a new pull request #1668:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1668
Fixes #1667
Changes proposed in this pull request:
- Specify highest version of Spring Framework to `5.2.9.RELEASE`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN commented on a change in pull request #1668: Specify highest version of Spring Framework in dependencyManagement
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on a change in pull request #1668:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1668#discussion_r513120901
##########
File path: elasticjob-lite/elasticjob-lite-spring/pom.xml
##########
@@ -34,7 +34,7 @@
<properties>
<springboot.version>2.3.1.RELEASE</springboot.version>
- <springframework.version>[3.1.0.RELEASE,)</springframework.version>
Review comment:
The class `org.springframework.util.ConcurrentLruCache` is added since `5.3.0`.
If we don't specify the upper bound of Spring version, a part of Spring modules will be upgraded to `5.3.0`.
But some modules are still the lower version.
Ref: https://github.com/spring-projects/spring-framework/blob/master/spring-core/src/main/java/org/springframework/util/ConcurrentLruCache.java
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] codecov-io commented on pull request #1668: Specify upper bound of Spring Framework version in dependencyManagement
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1668:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1668#issuecomment-717675875
# [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1668?src=pr&el=h1) Report
> Merging [#1668](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1668?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/5112c6ecf27357e4a9b924d916905dfa25f42f6d?el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1668?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1668 +/- ##
============================================
- Coverage 86.06% 86.03% -0.04%
Complexity 105 105
============================================
Files 251 251
Lines 5677 5677
Branches 875 875
============================================
- Hits 4886 4884 -2
- Misses 476 477 +1
- Partials 315 316 +1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1668?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...e/shardingsphere/elasticjob/infra/env/IpUtils.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1668/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLWluZnJhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9pbmZyYS9lbnYvSXBVdGlscy5qYXZh) | `60.00% <0.00%> (-3.08%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1668?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1668?src=pr&el=footer). Last update [5112c6e...850d301](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1668?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] terrymanu merged pull request #1668: Specify upper bound of Spring Framework version in dependencyManagement
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #1668:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1668
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org